Skip to content

Commit 9669e9e

Browse files
committed
Fix webhook options deprecation notes
1 parent 76865b2 commit 9669e9e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

pkg/manager/manager.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import (
3333
"k8s.io/client-go/tools/leaderelection/resourcelock"
3434
"k8s.io/client-go/tools/record"
3535
"k8s.io/utils/pointer"
36+
3637
"sigs.k8s.io/controller-runtime/pkg/cache"
3738
"sigs.k8s.io/controller-runtime/pkg/client"
3839
"sigs.k8s.io/controller-runtime/pkg/cluster"
@@ -281,12 +282,12 @@ type Options struct {
281282
// Port is the port that the webhook server serves at.
282283
// It is used to set webhook.Server.Port if WebhookServer is not set.
283284
//
284-
// Deprecated: Use WebhookServer.Port instead.
285+
// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
285286
Port int
286287
// Host is the hostname that the webhook server binds to.
287288
// It is used to set webhook.Server.Host if WebhookServer is not set.
288289
//
289-
// Deprecated: Use WebhookServer.Host instead.
290+
// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
290291
Host string
291292

292293
// CertDir is the directory that contains the server key and certificate.
@@ -295,12 +296,12 @@ type Options struct {
295296
// must be named tls.key and tls.crt, respectively.
296297
// It is used to set webhook.Server.CertDir if WebhookServer is not set.
297298
//
298-
// Deprecated: Use WebhookServer.CertDir instead.
299+
// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
299300
CertDir string
300301

301302
// TLSOpts is used to allow configuring the TLS config used for the webhook server.
302303
//
303-
// Deprecated: Use WebhookServer.TLSConfig instead.
304+
// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
304305
TLSOpts []func(*tls.Config)
305306

306307
// WebhookServer is an externally configured webhook.Server. By default,

0 commit comments

Comments
 (0)