Skip to content

Commit 8507812

Browse files
authored
Merge pull request #809 from christopherhein/chore/add-design-folder
✨📖 Adding designs folder and sample template
2 parents 4c789c1 + 59d237f commit 8507812

File tree

3 files changed

+58
-0
lines changed

3 files changed

+58
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Documentation:
1111
- [Creating a manager](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/manager#example-New)
1212
- [Creating a controller](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/controller#example-New)
1313
- [Examples](https://github.com/kubernetes-sigs/controller-runtime/blob/master/examples)
14+
- [Designs](https://github.com/kubernetes-sigs/controller-runtime/blob/master/designs)
1415

1516
# Versioning, Maintenance, and Compatibility
1617

designs/README.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
Designs
2+
=======
3+
4+
These are design documents for changes to Controller Runtime They exist
5+
to help document the design processes that go into writing Controller
6+
Runtime, but may not be up-to-date (more below).
7+
8+
Not all changes to Controller Runtime need a design document -- only major
9+
ones. use your best judgement.
10+
11+
When submitting a design document, we encourage having written
12+
a proof-of-concept, and it's perfectly acceptable to submit the
13+
proof-of-concept PR simultaneously with the design document, as the
14+
proof-of-concept process can help iron out wrinkles and can help with the
15+
`Example` section of the template.
16+
17+
## Out-of-Date Designs
18+
19+
**Controller Runtime documentation
20+
[GoDoc](https://godoc.org/sigs.k8s.io/controller-runtime) should be
21+
considered the canonical, update-to-date reference and architectural
22+
documentation** for Controller Runtime.
23+
24+
However, if you see an out-of-date design document, feel free to submit
25+
a PR marking it as such, and add an addendum linking to issues documenting
26+
why things changed. For example:
27+
28+
```markdown
29+
30+
# Out of Date
31+
32+
This change is out of date. It turns out curly braces a frustrating to
33+
type, so we had to abandon functions entirely, and have users specify
34+
custom functionality using strings of Common LISP instead. See #000 for
35+
more information.
36+
```

designs/template.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
Title of the Design
2+
===================
3+
4+
<!-- Describe your change here. This is purposefully freeform: we want
5+
enough information to evaluate the design, but not so much that you're
6+
annoyed by the overall design process and decide to bake cookies instead.
7+
-->
8+
9+
## Example
10+
11+
<!-- Specify an example of how the user would use this. It helps other
12+
contributors get a feel for how this will look in real code, and provides
13+
a good opportunity to evaluate the end-user feel of the code for yourself.
14+
15+
If you find yourself groaning at verbosity, copy-and-pasting a lot, or
16+
writing a bunch of tiny helper functions, it's a good indication that you
17+
might need to re-evaluate the user experience of your design.
18+
19+
This is also a good opportunity to stop and write a proof-of-concept, if
20+
you haven't already, which should help catch practical nits with the
21+
design. -->

0 commit comments

Comments
 (0)