Merge pull request #2252 from varshaprasad96/fix-bug/cache

k8s-ci-robot · web-flow · commit 7982358244ab · 2023-03-28T06:36:22.000-07:00
🐛 fix a bug in multinamespaced cache implementation
diff --git a/pkg/cache/multi_namespace_cache.go b/pkg/cache/multi_namespace_cache.go
@@ -197,7 +197,7 @@ func (c *multiNamespaceCache) WaitForCacheSync(ctx context.Context) bool {
 func (c *multiNamespaceCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error {
 	isNamespaced, err := apiutil.IsObjectNamespaced(obj, c.Scheme, c.RESTMapper)
 	if err != nil {
-		return nil //nolint:nilerr
+		return err
 	}
 
 	if !isNamespaced {

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ func (c *multiNamespaceCache) WaitForCacheSync(ctx context.Context) bool {`
`197`	`197`	`func (c *multiNamespaceCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error {`
`198`	`198`	`isNamespaced, err := apiutil.IsObjectNamespaced(obj, c.Scheme, c.RESTMapper)`
`199`	`199`	`if err != nil {`
`200`		`- return nil //nolint:nilerr`
	`200`	`+ return err`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`if !isNamespaced {`