Skip to content

Commit 705bd0c

Browse files
committed
fix: fix testcases
Signed-off-by: STRRL <[email protected]>
1 parent e4411c4 commit 705bd0c

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

pkg/log/zap/kube_aware_logger_sink.go renamed to pkg/log/zap/kube_aware_logr_logger_sink.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ type KubeAwareLogSink struct {
3333
kubeAwareEnabled *atomic.Bool
3434
}
3535

36-
// NewKubeAwareLogger return the wrapper with existed logr.Logger.
36+
// NewKubeAwareLogrLogger return the wrapper with existed logr.Logger.
3737
// logger is the backend logger.
3838
// kubeAwareEnabled is the flag to enable kube aware logging.
39-
func NewKubeAwareLogger(logger logr.Logger, kubeAwareEnabled bool) logr.Logger {
39+
func NewKubeAwareLogrLogger(logger logr.Logger, kubeAwareEnabled bool) logr.Logger {
4040
return logr.New(NewKubeAwareLogSink(logger.GetSink(), kubeAwareEnabled))
4141
}
4242

@@ -114,9 +114,9 @@ func (k *KubeAwareLogSink) wrapKeyAndValues(keysAndValues []interface{}) []inter
114114

115115
switch val := item.(type) {
116116
case runtime.Object:
117-
result[i] = &kubeObjectWrapper{obj: val}
117+
result[i] = &logrLoggerKubeObjectWrapper{obj: val}
118118
case types.NamespacedName:
119-
result[i] = &namespacedNameWrapper{NamespacedName: val}
119+
result[i] = &logrLoggerNamespacedNameWrapper{NamespacedName: val}
120120
default:
121121
result[i] = item
122122
}

pkg/log/zap/kube_object_wrapper.go renamed to pkg/log/zap/logr_logger_kube_object_wrapper.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ func (w *logrLoggerKubeObjectWrapper) MarshalLog() interface{} {
3434
result := make(map[string]string)
3535

3636
if reflect.ValueOf(w.obj).IsNil() {
37-
// best effort ,noop
38-
return nil
37+
// keep same behavior with kubeObjectWrapper.MarshalLogObject
38+
return "got nil for runtime.Object"
3939
}
4040

4141
if gvk := w.obj.GetObjectKind().GroupVersionKind(); gvk.Version != "" {

pkg/log/zap/zap.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ type NewEncoderFunc func(...EncoderConfigOption) zapcore.Encoder
4141
// information and Namespace/Name to the log.
4242
func New(opts ...Opts) logr.Logger {
4343
zaprLogger := zapr.NewLogger(NewRaw(opts...))
44-
return NewKubeAwareLogger(zaprLogger, true)
44+
return NewKubeAwareLogrLogger(zaprLogger, true)
4545
}
4646

4747
// Opts allows to manipulate Options.

0 commit comments

Comments
 (0)