chore: rename validator_warn_test.go to validator_test.go

STRRL · STRRL · commit 6e2a023e4dd0 · 2023-04-13T22:12:25.000+08:00
and fix compilation errors

Signed-off-by: STRRL &lt;im@strrl.dev&gt;
diff --git a/examples/builtins/validatingwebhook.go b/examples/builtins/validatingwebhook.go
@@ -32,34 +32,34 @@ import (
 type podValidator struct{}
 
 // validate admits a pod if a specific annotation exists.
-func (v *podValidator) validate(ctx context.Context, obj runtime.Object) error {
+func (v *podValidator) validate(ctx context.Context, obj runtime.Object) ([]string, error) {
 	log := logf.FromContext(ctx)
 	pod, ok := obj.(*corev1.Pod)
 	if !ok {
-		return fmt.Errorf("expected a Pod but got a %T", obj)
+		return nil, fmt.Errorf("expected a Pod but got a %T", obj)
 	}
 
 	log.Info("Validating Pod")
 	key := "example-mutating-admission-webhook"
 	anno, found := pod.Annotations[key]
 	if !found {
-		return fmt.Errorf("missing annotation %s", key)
+		return nil, fmt.Errorf("missing annotation %s", key)
 	}
 	if anno != "foo" {
-		return fmt.Errorf("annotation %s did not have value %q", key, "foo")
+		return nil, fmt.Errorf("annotation %s did not have value %q", key, "foo")
 	}
 
-	return nil
+	return nil, nil
 }
 
-func (v *podValidator) ValidateCreate(ctx context.Context, obj runtime.Object) error {
+func (v *podValidator) ValidateCreate(ctx context.Context, obj runtime.Object) ([]string, error) {
 	return v.validate(ctx, obj)
 }
 
-func (v *podValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) error {
+func (v *podValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) ([]string, error) {
 	return v.validate(ctx, newObj)
 }
 
-func (v *podValidator) ValidateDelete(ctx context.Context, obj runtime.Object) error {
+func (v *podValidator) ValidateDelete(ctx context.Context, obj runtime.Object) ([]string, error) {
 	return v.validate(ctx, obj)
 }
diff --git a/examples/crd/pkg/resource.go b/examples/crd/pkg/resource.go
@@ -66,41 +66,41 @@ type ChaosPodList struct {
 var _ webhook.Validator = &ChaosPod{}
 
 // ValidateCreate implements webhookutil.validator so a webhook will be registered for the type
-func (c *ChaosPod) ValidateCreate() error {
+func (c *ChaosPod) ValidateCreate() ([]string, error) {
 	log.Info("validate create", "name", c.Name)
 
 	if c.Spec.NextStop.Before(&metav1.Time{Time: time.Now()}) {
-		return fmt.Errorf(".spec.nextStop must be later than current time")
+		return nil, fmt.Errorf(".spec.nextStop must be later than current time")
 	}
-	return nil
+	return nil, nil
 }
 
 // ValidateUpdate implements webhookutil.validator so a webhook will be registered for the type
-func (c *ChaosPod) ValidateUpdate(old runtime.Object) error {
+func (c *ChaosPod) ValidateUpdate(old runtime.Object) ([]string, error) {
 	log.Info("validate update", "name", c.Name)
 
 	if c.Spec.NextStop.Before(&metav1.Time{Time: time.Now()}) {
-		return fmt.Errorf(".spec.nextStop must be later than current time")
+		return nil, fmt.Errorf(".spec.nextStop must be later than current time")
 	}
 
 	oldC, ok := old.(*ChaosPod)
 	if !ok {
-		return fmt.Errorf("expect old object to be a %T instead of %T", oldC, old)
+		return nil, fmt.Errorf("expect old object to be a %T instead of %T", oldC, old)
 	}
 	if c.Spec.NextStop.After(oldC.Spec.NextStop.Add(time.Hour)) {
-		return fmt.Errorf("it is not allowed to delay.spec.nextStop for more than 1 hour")
+		return nil, fmt.Errorf("it is not allowed to delay.spec.nextStop for more than 1 hour")
 	}
-	return nil
+	return nil, nil
 }
 
 // ValidateDelete implements webhookutil.validator so a webhook will be registered for the type
-func (c *ChaosPod) ValidateDelete() error {
+func (c *ChaosPod) ValidateDelete() ([]string, error) {
 	log.Info("validate delete", "name", c.Name)
 
 	if c.Spec.NextStop.Before(&metav1.Time{Time: time.Now()}) {
-		return fmt.Errorf(".spec.nextStop must be later than current time")
+		return nil, fmt.Errorf(".spec.nextStop must be later than current time")
 	}
-	return nil
+	return nil, nil
 }
 
 // +kubebuilder:webhook:path=/mutate-chaosapps-metamagical-io-v1-chaospod,mutating=true,failurePolicy=fail,groups=chaosapps.metamagical.io,resources=chaospods,verbs=create;update,versions=v1,name=mchaospod.kb.io
diff --git a/pkg/builder/webhook_test.go b/pkg/builder/webhook_test.go
@@ -749,39 +749,39 @@ func (*TestValidatorList) DeepCopyObject() runtime.Object   { return nil }
 
 var _ admission.Validator = &TestValidator{}
 
-func (v *TestValidator) ValidateCreate() error {
+func (v *TestValidator) ValidateCreate() ([]string, error) {
 	if v.Panic {
 		panic("fake panic test")
 	}
 	if v.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
-	return nil
+	return nil, nil
 }
 
-func (v *TestValidator) ValidateUpdate(old runtime.Object) error {
+func (v *TestValidator) ValidateUpdate(old runtime.Object) ([]string, error) {
 	if v.Panic {
 		panic("fake panic test")
 	}
 	if v.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
 	if oldObj, ok := old.(*TestValidator); !ok {
-		return fmt.Errorf("the old object is expected to be %T", oldObj)
+		return nil, fmt.Errorf("the old object is expected to be %T", oldObj)
 	} else if v.Replica < oldObj.Replica {
-		return fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, oldObj.Replica)
+		return nil, fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, oldObj.Replica)
 	}
-	return nil
+	return nil, nil
 }
 
-func (v *TestValidator) ValidateDelete() error {
+func (v *TestValidator) ValidateDelete() ([]string, error) {
 	if v.Panic {
 		panic("fake panic test")
 	}
 	if v.Replica > 0 {
-		return errors.New("number of replica should be less than or equal to 0 to delete")
+		return nil, errors.New("number of replica should be less than or equal to 0 to delete")
 	}
-	return nil
+	return nil, nil
 }
 
 // TestDefaultValidator.
@@ -824,25 +824,25 @@ func (dv *TestDefaultValidator) Default() {
 
 var _ admission.Validator = &TestDefaultValidator{}
 
-func (dv *TestDefaultValidator) ValidateCreate() error {
+func (dv *TestDefaultValidator) ValidateCreate() ([]string, error) {
 	if dv.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
-	return nil
+	return nil, nil
 }
 
-func (dv *TestDefaultValidator) ValidateUpdate(old runtime.Object) error {
+func (dv *TestDefaultValidator) ValidateUpdate(old runtime.Object) ([]string, error) {
 	if dv.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
-	return nil
+	return nil, nil
 }
 
-func (dv *TestDefaultValidator) ValidateDelete() error {
+func (dv *TestDefaultValidator) ValidateDelete() ([]string, error) {
 	if dv.Replica > 0 {
-		return errors.New("number of replica should be less than or equal to 0 to delete")
+		return nil, errors.New("number of replica should be less than or equal to 0 to delete")
 	}
-	return nil
+	return nil, nil
 }
 
 // TestCustomDefaulter.
@@ -872,59 +872,59 @@ var _ admission.CustomDefaulter = &TestCustomDefaulter{}
 
 type TestCustomValidator struct{}
 
-func (*TestCustomValidator) ValidateCreate(ctx context.Context, obj runtime.Object) error {
+func (*TestCustomValidator) ValidateCreate(ctx context.Context, obj runtime.Object) ([]string, error) {
 	logf.FromContext(ctx).Info("Validating object")
 	req, err := admission.RequestFromContext(ctx)
 	if err != nil {
-		return fmt.Errorf("expected admission.Request in ctx: %w", err)
+		return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)
 	}
 	if req.Kind.Kind != testValidatorKind {
-		return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
+		return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
 	}
 
 	v := obj.(*TestValidator) //nolint:ifshort
 	if v.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
-	return nil
+	return nil, nil
 }
 
-func (*TestCustomValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) error {
+func (*TestCustomValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) ([]string, error) {
 	logf.FromContext(ctx).Info("Validating object")
 	req, err := admission.RequestFromContext(ctx)
 	if err != nil {
-		return fmt.Errorf("expected admission.Request in ctx: %w", err)
+		return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)
 	}
 	if req.Kind.Kind != testValidatorKind {
-		return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
+		return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
 	}
 
 	v := newObj.(*TestValidator)
 	old := oldObj.(*TestValidator)
 	if v.Replica < 0 {
-		return errors.New("number of replica should be greater than or equal to 0")
+		return nil, errors.New("number of replica should be greater than or equal to 0")
 	}
 	if v.Replica < old.Replica {
-		return fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, old.Replica)
+		return nil, fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, old.Replica)
 	}
-	return nil
+	return nil, nil
 }
 
-func (*TestCustomValidator) ValidateDelete(ctx context.Context, obj runtime.Object) error {
+func (*TestCustomValidator) ValidateDelete(ctx context.Context, obj runtime.Object) ([]string, error) {
 	logf.FromContext(ctx).Info("Validating object")
 	req, err := admission.RequestFromContext(ctx)
 	if err != nil {
-		return fmt.Errorf("expected admission.Request in ctx: %w", err)
+		return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)
 	}
 	if req.Kind.Kind != testValidatorKind {
-		return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
+		return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)
 	}
 
 	v := obj.(*TestValidator) //nolint:ifshort
 	if v.Replica > 0 {
-		return errors.New("number of replica should be less than or equal to 0 to delete")
+		return nil, errors.New("number of replica should be less than or equal to 0 to delete")
 	}
-	return nil
+	return nil, nil
 }
 
 var _ admission.CustomValidator = &TestCustomValidator{}
diff --git a/pkg/webhook/admission/validator.go b/pkg/webhook/admission/validator.go
@@ -55,16 +55,16 @@ func (h *validatingHandler) Handle(ctx context.Context, req Request) Response {
 	if h.validator == nil {
 		panic("validator should never be nil")
 	}
-
-	ctx = NewContextWithRequest(ctx, req)
-
 	// Get the object in the request
 	obj := h.validator.DeepCopyObject().(Validator)
 
 	var err error
 	var warnings []string
 
 	switch req.Operation {
+	case v1.Connect:
+		// No validation for connect requests.
+		// TODO(vincepri): Should we validate CONNECT requests? In what cases?
 	case v1.Create:
 		err = h.decoder.Decode(req, obj)
 		if err != nil {
diff --git a/pkg/webhook/admission/validator_test.go b/pkg/webhook/admission/validator_test.go
diff --git a/pkg/webhook/alias.go b/pkg/webhook/alias.go
@@ -29,9 +29,6 @@ type Defaulter = admission.Defaulter
 // Validator defines functions for validating an operation.
 type Validator = admission.Validator
 
-// ValidatorWarn like Validator, but could return warnings.
-type ValidatorWarn = admission.ValidatorWarn
-
 // CustomDefaulter defines functions for setting defaults on resources.
 type CustomDefaulter = admission.CustomDefaulter
 

Original file line number	Diff line number	Diff line change
`@@ -32,34 +32,34 @@ import (`
`32`	`32`	`type podValidator struct{}`
`33`	`33`
`34`	`34`	`// validate admits a pod if a specific annotation exists.`
`35`		`-func (v *podValidator) validate(ctx context.Context, obj runtime.Object) error {`
	`35`	`+func (v *podValidator) validate(ctx context.Context, obj runtime.Object) ([]string, error) {`
`36`	`36`	`log := logf.FromContext(ctx)`
`37`	`37`	`pod, ok := obj.(*corev1.Pod)`
`38`	`38`	`if !ok {`
`39`		`- return fmt.Errorf("expected a Pod but got a %T", obj)`
	`39`	`+ return nil, fmt.Errorf("expected a Pod but got a %T", obj)`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`log.Info("Validating Pod")`
`43`	`43`	`key := "example-mutating-admission-webhook"`
`44`	`44`	`anno, found := pod.Annotations[key]`
`45`	`45`	`if !found {`
`46`		`- return fmt.Errorf("missing annotation %s", key)`
	`46`	`+ return nil, fmt.Errorf("missing annotation %s", key)`
`47`	`47`	`}`
`48`	`48`	`if anno != "foo" {`
`49`		`- return fmt.Errorf("annotation %s did not have value %q", key, "foo")`
	`49`	`+ return nil, fmt.Errorf("annotation %s did not have value %q", key, "foo")`
`50`	`50`	`}`
`51`	`51`
`52`		`- return nil`
	`52`	`+ return nil, nil`
`53`	`53`	`}`
`54`	`54`
`55`		`-func (v *podValidator) ValidateCreate(ctx context.Context, obj runtime.Object) error {`
	`55`	`+func (v *podValidator) ValidateCreate(ctx context.Context, obj runtime.Object) ([]string, error) {`
`56`	`56`	`return v.validate(ctx, obj)`
`57`	`57`	`}`
`58`	`58`
`59`		`-func (v *podValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) error {`
	`59`	`+func (v *podValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) ([]string, error) {`
`60`	`60`	`return v.validate(ctx, newObj)`
`61`	`61`	`}`
`62`	`62`
`63`		`-func (v *podValidator) ValidateDelete(ctx context.Context, obj runtime.Object) error {`
	`63`	`+func (v *podValidator) ValidateDelete(ctx context.Context, obj runtime.Object) ([]string, error) {`
`64`	`64`	`return v.validate(ctx, obj)`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -749,39 +749,39 @@ func (*TestValidatorList) DeepCopyObject() runtime.Object { return nil }`
`749`	`749`
`750`	`750`	`var _ admission.Validator = &TestValidator{}`
`751`	`751`
`752`		`-func (v *TestValidator) ValidateCreate() error {`
	`752`	`+func (v *TestValidator) ValidateCreate() ([]string, error) {`
`753`	`753`	`if v.Panic {`
`754`	`754`	`panic("fake panic test")`
`755`	`755`	`}`
`756`	`756`	`if v.Replica < 0 {`
`757`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`757`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`758`	`758`	`}`
`759`		`- return nil`
	`759`	`+ return nil, nil`
`760`	`760`	`}`
`761`	`761`
`762`		`-func (v *TestValidator) ValidateUpdate(old runtime.Object) error {`
	`762`	`+func (v *TestValidator) ValidateUpdate(old runtime.Object) ([]string, error) {`
`763`	`763`	`if v.Panic {`
`764`	`764`	`panic("fake panic test")`
`765`	`765`	`}`
`766`	`766`	`if v.Replica < 0 {`
`767`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`767`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`768`	`768`	`}`
`769`	`769`	`if oldObj, ok := old.(*TestValidator); !ok {`
`770`		`- return fmt.Errorf("the old object is expected to be %T", oldObj)`
	`770`	`+ return nil, fmt.Errorf("the old object is expected to be %T", oldObj)`
`771`	`771`	`} else if v.Replica < oldObj.Replica {`
`772`		`- return fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, oldObj.Replica)`
	`772`	`+ return nil, fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, oldObj.Replica)`
`773`	`773`	`}`
`774`		`- return nil`
	`774`	`+ return nil, nil`
`775`	`775`	`}`
`776`	`776`
`777`		`-func (v *TestValidator) ValidateDelete() error {`
	`777`	`+func (v *TestValidator) ValidateDelete() ([]string, error) {`
`778`	`778`	`if v.Panic {`
`779`	`779`	`panic("fake panic test")`
`780`	`780`	`}`
`781`	`781`	`if v.Replica > 0 {`
`782`		`- return errors.New("number of replica should be less than or equal to 0 to delete")`
	`782`	`+ return nil, errors.New("number of replica should be less than or equal to 0 to delete")`
`783`	`783`	`}`
`784`		`- return nil`
	`784`	`+ return nil, nil`
`785`	`785`	`}`
`786`	`786`
`787`	`787`	`// TestDefaultValidator.`
`@@ -824,25 +824,25 @@ func (dv *TestDefaultValidator) Default() {`
`824`	`824`
`825`	`825`	`var _ admission.Validator = &TestDefaultValidator{}`
`826`	`826`
`827`		`-func (dv *TestDefaultValidator) ValidateCreate() error {`
	`827`	`+func (dv *TestDefaultValidator) ValidateCreate() ([]string, error) {`
`828`	`828`	`if dv.Replica < 0 {`
`829`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`829`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`830`	`830`	`}`
`831`		`- return nil`
	`831`	`+ return nil, nil`
`832`	`832`	`}`
`833`	`833`
`834`		`-func (dv *TestDefaultValidator) ValidateUpdate(old runtime.Object) error {`
	`834`	`+func (dv *TestDefaultValidator) ValidateUpdate(old runtime.Object) ([]string, error) {`
`835`	`835`	`if dv.Replica < 0 {`
`836`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`836`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`837`	`837`	`}`
`838`		`- return nil`
	`838`	`+ return nil, nil`
`839`	`839`	`}`
`840`	`840`
`841`		`-func (dv *TestDefaultValidator) ValidateDelete() error {`
	`841`	`+func (dv *TestDefaultValidator) ValidateDelete() ([]string, error) {`
`842`	`842`	`if dv.Replica > 0 {`
`843`		`- return errors.New("number of replica should be less than or equal to 0 to delete")`
	`843`	`+ return nil, errors.New("number of replica should be less than or equal to 0 to delete")`
`844`	`844`	`}`
`845`		`- return nil`
	`845`	`+ return nil, nil`
`846`	`846`	`}`
`847`	`847`
`848`	`848`	`// TestCustomDefaulter.`
`@@ -872,59 +872,59 @@ var _ admission.CustomDefaulter = &TestCustomDefaulter{}`
`872`	`872`
`873`	`873`	`type TestCustomValidator struct{}`
`874`	`874`
`875`		`-func (*TestCustomValidator) ValidateCreate(ctx context.Context, obj runtime.Object) error {`
	`875`	`+func (*TestCustomValidator) ValidateCreate(ctx context.Context, obj runtime.Object) ([]string, error) {`
`876`	`876`	`logf.FromContext(ctx).Info("Validating object")`
`877`	`877`	`req, err := admission.RequestFromContext(ctx)`
`878`	`878`	`if err != nil {`
`879`		`- return fmt.Errorf("expected admission.Request in ctx: %w", err)`
	`879`	`+ return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)`
`880`	`880`	`}`
`881`	`881`	`if req.Kind.Kind != testValidatorKind {`
`882`		`- return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
	`882`	`+ return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
`883`	`883`	`}`
`884`	`884`
`885`	`885`	`v := obj.(*TestValidator) //nolint:ifshort`
`886`	`886`	`if v.Replica < 0 {`
`887`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`887`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`888`	`888`	`}`
`889`		`- return nil`
	`889`	`+ return nil, nil`
`890`	`890`	`}`
`891`	`891`
`892`		`-func (*TestCustomValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) error {`
	`892`	`+func (*TestCustomValidator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) ([]string, error) {`
`893`	`893`	`logf.FromContext(ctx).Info("Validating object")`
`894`	`894`	`req, err := admission.RequestFromContext(ctx)`
`895`	`895`	`if err != nil {`
`896`		`- return fmt.Errorf("expected admission.Request in ctx: %w", err)`
	`896`	`+ return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)`
`897`	`897`	`}`
`898`	`898`	`if req.Kind.Kind != testValidatorKind {`
`899`		`- return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
	`899`	`+ return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
`900`	`900`	`}`
`901`	`901`
`902`	`902`	`v := newObj.(*TestValidator)`
`903`	`903`	`old := oldObj.(*TestValidator)`
`904`	`904`	`if v.Replica < 0 {`
`905`		`- return errors.New("number of replica should be greater than or equal to 0")`
	`905`	`+ return nil, errors.New("number of replica should be greater than or equal to 0")`
`906`	`906`	`}`
`907`	`907`	`if v.Replica < old.Replica {`
`908`		`- return fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, old.Replica)`
	`908`	`+ return nil, fmt.Errorf("new replica %v should not be fewer than old replica %v", v.Replica, old.Replica)`
`909`	`909`	`}`
`910`		`- return nil`
	`910`	`+ return nil, nil`
`911`	`911`	`}`
`912`	`912`
`913`		`-func (*TestCustomValidator) ValidateDelete(ctx context.Context, obj runtime.Object) error {`
	`913`	`+func (*TestCustomValidator) ValidateDelete(ctx context.Context, obj runtime.Object) ([]string, error) {`
`914`	`914`	`logf.FromContext(ctx).Info("Validating object")`
`915`	`915`	`req, err := admission.RequestFromContext(ctx)`
`916`	`916`	`if err != nil {`
`917`		`- return fmt.Errorf("expected admission.Request in ctx: %w", err)`
	`917`	`+ return nil, fmt.Errorf("expected admission.Request in ctx: %w", err)`
`918`	`918`	`}`
`919`	`919`	`if req.Kind.Kind != testValidatorKind {`
`920`		`- return fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
	`920`	`+ return nil, fmt.Errorf("expected Kind TestValidator got %q", req.Kind.Kind)`
`921`	`921`	`}`
`922`	`922`
`923`	`923`	`v := obj.(*TestValidator) //nolint:ifshort`
`924`	`924`	`if v.Replica > 0 {`
`925`		`- return errors.New("number of replica should be less than or equal to 0 to delete")`
	`925`	`+ return nil, errors.New("number of replica should be less than or equal to 0 to delete")`
`926`	`926`	`}`
`927`		`- return nil`
	`927`	`+ return nil, nil`
`928`	`928`	`}`
`929`	`929`
`930`	`930`	`var _ admission.CustomValidator = &TestCustomValidator{}`