Skip to content

Commit 2062f3a

Browse files
committed
🌱 Remove redundant WithLowPriorityWhenUnchanged in builder
The handlers themselves already support this, so there is no need to also do it in the builder.
1 parent 2af3164 commit 2062f3a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/builder/controller.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ func (blder *TypedBuilder[request]) Watches(
163163
) *TypedBuilder[request] {
164164
input := WatchesInput[request]{
165165
obj: object,
166-
handler: handler.WithLowPriorityWhenUnchanged(eventHandler),
166+
handler: eventHandler,
167167
}
168168
for _, opt := range opts {
169169
opt.ApplyToWatches(&input)
@@ -317,7 +317,7 @@ func (blder *TypedBuilder[request]) doWatch() error {
317317
}
318318

319319
var hdler handler.TypedEventHandler[client.Object, request]
320-
reflect.ValueOf(&hdler).Elem().Set(reflect.ValueOf(handler.WithLowPriorityWhenUnchanged(&handler.EnqueueRequestForObject{})))
320+
reflect.ValueOf(&hdler).Elem().Set(reflect.ValueOf(&handler.EnqueueRequestForObject{}))
321321
allPredicates := append([]predicate.Predicate(nil), blder.globalPredicates...)
322322
allPredicates = append(allPredicates, blder.forInput.predicates...)
323323
src := source.TypedKind(blder.mgr.GetCache(), obj, hdler, allPredicates...)
@@ -341,11 +341,11 @@ func (blder *TypedBuilder[request]) doWatch() error {
341341
}
342342

343343
var hdler handler.TypedEventHandler[client.Object, request]
344-
reflect.ValueOf(&hdler).Elem().Set(reflect.ValueOf(handler.WithLowPriorityWhenUnchanged(handler.EnqueueRequestForOwner(
344+
reflect.ValueOf(&hdler).Elem().Set(reflect.ValueOf(handler.EnqueueRequestForOwner(
345345
blder.mgr.GetScheme(), blder.mgr.GetRESTMapper(),
346346
blder.forInput.object,
347347
opts...,
348-
))))
348+
)))
349349
allPredicates := append([]predicate.Predicate(nil), blder.globalPredicates...)
350350
allPredicates = append(allPredicates, own.predicates...)
351351
src := source.TypedKind(blder.mgr.GetCache(), obj, hdler, allPredicates...)

0 commit comments

Comments
 (0)