Skip to content

Commit 15868a0

Browse files
committed
Provide more information on deprecating ComponentConfig
Signed-off-by: Vince Prignano <[email protected]>
1 parent 2ebab48 commit 15868a0

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

pkg/manager/manager.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,12 @@ func New(config *rest.Config, options Options) (Manager, error) {
455455
// any options already set on Options will be ignored, this is used to allow
456456
// cli flags to override anything specified in the config file.
457457
//
458-
// Deprecated: This function has been deprecated and will be removed in a future release.
458+
// Deprecated: This function has been deprecated and will be removed in a future release,
459+
// The Component Configuration package has been unmaintained for over a year and is no longer
460+
// actively developed. Users should migrate to their own configuration format
461+
// and configure Manager.Options directly.
462+
// See https://github.com/kubernetes-sigs/controller-runtime/issues/895
463+
// for more information, feedback, and comments.
459464
func (o Options) AndFrom(loader config.ControllerManagerConfiguration) (Options, error) {
460465
newObj, err := loader.Complete()
461466
if err != nil {
@@ -515,7 +520,12 @@ func (o Options) AndFrom(loader config.ControllerManagerConfiguration) (Options,
515520

516521
// AndFromOrDie will use options.AndFrom() and will panic if there are errors.
517522
//
518-
// Deprecated: This function has been deprecated and will be removed in a future release.
523+
// Deprecated: This function has been deprecated and will be removed in a future release,
524+
// The Component Configuration package has been unmaintained for over a year and is no longer
525+
// actively developed. Users should migrate to their own configuration format
526+
// and configure Manager.Options directly.
527+
// See https://github.com/kubernetes-sigs/controller-runtime/issues/895
528+
// for more information, feedback, and comments.
519529
func (o Options) AndFromOrDie(loader config.ControllerManagerConfiguration) Options {
520530
o, err := o.AndFrom(loader)
521531
if err != nil {

0 commit comments

Comments
 (0)