Skip to content

Commit 896eb15

Browse files
authored
Merge pull request #56 from mukhoakash/api-update
Update the bucket info api and add namespace to BucketAccess client
2 parents 02ff3dd + 124be32 commit 896eb15

File tree

10 files changed

+100
-33
lines changed

10 files changed

+100
-33
lines changed

apis/bucket_info.go

+16-4
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,18 @@ import (
2222
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2323
)
2424

25+
type SecretS3 struct {
26+
Endpoint string `json:"endpoint"`
27+
Region string `json:"region"`
28+
AccessKeyID string `json:"accessKeyID"`
29+
AccessSecretKey string `json:"accessSecretKey"`
30+
}
31+
32+
type SecretAzure struct {
33+
AccessToken string `json:"acessToken"`
34+
ExpiryTimeStamp *metav1.Time `json:"expiryTimeStamp"`
35+
}
36+
2537
// +k8s:deepcopy-gen=false
2638
type BucketInfo struct {
2739
metav1.TypeMeta `json:",inline"`
@@ -42,11 +54,11 @@ type BucketInfoSpec struct {
4254
// IAM - implicit authentication of pods to the OSP based on service account mappings
4355
AuthenticationType AuthenticationType `json:"authenticationType"`
4456

45-
// Endpoint is the URL at which the bucket can be accessed
46-
Endpoint string `json:"endpoint"`
57+
// S3 - Details of S3 credentials
58+
S3 *SecretS3 `json:"secretS3"`
4759

48-
// Region is the vendor-defined region where the bucket "resides"
49-
Region string `json:"region"`
60+
// Azure - Details of Azure credentials
61+
Azure *SecretAzure `json:"secretAzure"`
5062

5163
// Protocols are the set of data APIs this bucket is expected to support.
5264
// The possible values for protocol are:

apis/objectstorage/v1alpha1/types.go

-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ type BucketAccessClassList struct {
256256
}
257257

258258
// +genclient
259-
// +genclient:nonNamespaced
260259
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
261260
// +kubebuilder:resource:scope=Namespaced
262261
// +kubebuilder:storageversion

client/clientset/versioned/typed/objectstorage/v1alpha1/bucketaccess.go

+13-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/clientset/versioned/typed/objectstorage/v1alpha1/fake/fake_bucketaccess.go

+18-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/clientset/versioned/typed/objectstorage/v1alpha1/fake/fake_objectstorage_client.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/clientset/versioned/typed/objectstorage/v1alpha1/objectstorage_client.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/informers/externalversions/objectstorage/v1alpha1/bucketaccess.go

+7-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/informers/externalversions/objectstorage/v1alpha1/interface.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/listers/objectstorage/v1alpha1/bucketaccess.go

+37-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/listers/objectstorage/v1alpha1/expansion_generated.go

+4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)