lint: fix checks for the json encoding function.

Author: MrDXY

.golangci.yml

@@ -18,7 +18,7 @@ linters:
   - dupword
   - durationcheck
   - errcheck
-  # - errchkjson
+  - errchkjson
   - exportloopref
   - gci
   # - ginkgolinter
@@ -54,6 +54,8 @@ linters:
   - whitespace
 
 linters-settings:
+  errchkjson:
+    check-error-free-encoding: true
   gci:
     local-prefixes: "sigs.k8s.io/cluster-api-provider-vsphere"
   godot:

pkg/services/vmoperator/vmopmachine.go

@@ -476,10 +476,7 @@ func addVolumes(ctx *vmware.SupervisorMachineContext, vm *vmoprv1.VirtualMachine
 			topology := []map[string]string{
 				{kubeTopologyZoneLabelKey: *zone},
 			}
-			b, err := json.Marshal(topology)
-			if err != nil {
-				return errors.Errorf("failed to marshal zone topology %q: %s", *zone, err)
-			}
+			b, _ := json.Marshal(topology)
 			pvc.Annotations = map[string]string{
 				"csi.vsphere.volume-requested-topology": string(b),
 			}

test/integration/integration_suite_test.go

@@ -325,8 +325,7 @@ func generateVirtualMachineImage() *vmoprv1.VirtualMachineImage {
 		},
 	}
 
-	rawJSON, err := json.Marshal(spec)
-	Expect(err).NotTo(HaveOccurred())
+	rawJSON, _ := json.Marshal(spec)
 
 	annotations[VirtualMachineDistributionProperty] = string(rawJSON)