lint: fix checks for the json encoding function.

Author: MrDXY

.golangci.yml

@@ -18,7 +18,7 @@ linters:
   - dupword
   - durationcheck
   - errcheck
-  # - errchkjson
+  - errchkjson
   - exportloopref
   - gci
   # - ginkgolinter

packaging/flavorgen/cmd/root.go

@@ -132,7 +132,11 @@ func generateSingle(flavor string) (string, error) {
 	case flavors.ClusterClass:
 		objs = flavors.ClusterClassTemplateWithKubeVIP()
 	case flavors.ClusterTopology:
-		objs = flavors.ClusterTopologyTemplateKubeVIP()
+		clusterTopologyTemplateKubeVIP, err := flavors.ClusterTopologyTemplateKubeVIP()
+		if err != nil {
+			return "", errors.Wrap(err, "failed to create ClusterTopologyTemplateKubeVIP")
+		}
+		objs = clusterTopologyTemplateKubeVIP
 		replacements = append(replacements, util.Replacement{
 			Kind:      "Cluster",
 			Name:      "${CLUSTER_NAME}",

packaging/flavorgen/flavors/flavors.go

@@ -19,6 +19,7 @@ package flavors
 import (
 	"fmt"
 
+	"github.com/pkg/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 
 	"sigs.k8s.io/cluster-api-provider-vsphere/packaging/flavorgen/flavors/crs"
@@ -54,8 +55,11 @@ func ClusterClassTemplateWithKubeVIP() []runtime.Object {
 	return ClusterClassTemplate
 }
 
-func ClusterTopologyTemplateKubeVIP() []runtime.Object {
-	cluster := newClusterClassCluster()
+func ClusterTopologyTemplateKubeVIP() ([]runtime.Object, error) {
+	cluster, err := newClusterTopologyCluster()
+	if err != nil {
+		return nil, errors.Wrap(err, "failed to create ClusterTopologyTemplateKubeVIP")
+	}
 	identitySecret := newIdentitySecret()
 	clusterResourceSet := newClusterResourceSet(cluster)
 	crsResourcesCSI := crs.CreateCrsResourceObjectsCSI(&clusterResourceSet)
@@ -67,7 +71,7 @@ func ClusterTopologyTemplateKubeVIP() []runtime.Object {
 	}
 	MultiNodeTemplate = append(MultiNodeTemplate, crsResourcesCSI...)
 	MultiNodeTemplate = append(MultiNodeTemplate, crsResourcesCPI...)
-	return MultiNodeTemplate
+	return MultiNodeTemplate, nil
 }
 
 func MultiNodeTemplateWithKubeVIP() []runtime.Object {

packaging/flavorgen/flavors/generators.go

@@ -20,6 +20,7 @@ import (
 	"encoding/json"
 	"fmt"
 
+	"github.com/pkg/errors"
 	corev1 "k8s.io/api/core/v1"
 	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -94,7 +95,11 @@ systemd:
         EnvironmentFile=/run/metadata/*`
 )
 
-func newClusterClassCluster() clusterv1.Cluster {
+func newClusterTopologyCluster() (clusterv1.Cluster, error) {
+	variables, err := clusterTopologyVariables()
+	if err != nil {
+		return clusterv1.Cluster{}, errors.Wrap(err, "failed to create ClusterTopologyCluster template")
+	}
 	return clusterv1.Cluster{
 		TypeMeta: metav1.TypeMeta{
 			APIVersion: clusterv1.GroupVersion.String(),
@@ -121,17 +126,34 @@ func newClusterClassCluster() clusterv1.Cluster {
 						},
 					},
 				},
-				Variables: clusterTopologyVariables(),
+				Variables: variables,
 			},
 		},
-	}
+	}, nil
 }
 
-func clusterTopologyVariables() []clusterv1.ClusterVariable {
-	sshKey, _ := json.Marshal(env.VSphereSSHAuthorizedKeysVar)
-	controlPlaneIP, _ := json.Marshal(env.ControlPlaneEndpointVar)
-	secretName, _ := json.Marshal(env.ClusterNameVar)
-	kubeVipPod, _ := json.Marshal(kubeVIPPodYaml())
+func clusterTopologyVariables() ([]clusterv1.ClusterVariable, error) {
+	sshKey, err := json.Marshal(env.VSphereSSHAuthorizedKeysVar)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to json-encode variable VSphereSSHAuthorizedKeysVar: %q", env.VSphereSSHAuthorizedKeysVar)
+	}
+	controlPlaneIP, err := json.Marshal(env.ControlPlaneEndpointVar)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to json-encode variable ControlPlaneEndpointVar: %q", env.ControlPlaneEndpointVar)
+	}
+	secretName, err := json.Marshal(env.ClusterNameVar)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to json-encode variable ClusterNameVar: %q", env.ClusterNameVar)
+	}
+	kubeVipPodYaml := kubeVIPPodYaml()
+	kubeVipPod, err := json.Marshal(kubeVipPodYaml)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to json-encode variable kubeVipPod: %q", kubeVipPodYaml)
+	}
+	infraServerValue, err := getInfraServerValue()
+	if err != nil {
+		return nil, err
+	}
 	return []clusterv1.ClusterVariable{
 		{
 			Name: "sshKey",
@@ -142,7 +164,7 @@ func clusterTopologyVariables() []clusterv1.ClusterVariable {
 		{
 			Name: "infraServer",
 			Value: apiextensionsv1.JSON{
-				Raw: getInfraServerValue(),
+				Raw: infraServerValue,
 			},
 		},
 		{
@@ -164,15 +186,19 @@ func clusterTopologyVariables() []clusterv1.ClusterVariable {
 				Raw: secretName,
 			},
 		},
-	}
+	}, nil
 }
 
-func getInfraServerValue() []byte {
-	byteArr, _ := json.Marshal(map[string]string{
+func getInfraServerValue() ([]byte, error) {
+	byteArr, err := json.Marshal(map[string]string{
 		"url":        env.VSphereServerVar,
 		"thumbprint": env.VSphereThumbprint,
 	})
-	return byteArr
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to json-encode, VSphereServerVar: %s, VSphereThumbprint: %s",
+			env.VSphereServerVar, env.VSphereThumbprint)
+	}
+	return byteArr, nil
 }
 
 func newVSphereCluster() infrav1.VSphereCluster {