Skip to content

Allow modifications to dnsNameservers in OpenstackCluster spec post-deployment #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pbasov opened this issue Mar 10, 2025 · 1 comment · May be fixed by #2511
Open

Allow modifications to dnsNameservers in OpenstackCluster spec post-deployment #2468

pbasov opened this issue Mar 10, 2025 · 1 comment · May be fixed by #2511
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pbasov
Copy link

pbasov commented Mar 10, 2025

/kind feature

Describe the solution you'd like
Right now this is immutable:

spec:
  config
    managedSubnets:
    - cidr: 10.6.0.0/24
      dnsNameservers:
      - 1.1.1.1
      - 8.8.8.8

What if I would like to change the DNS servers after I have the cluster up?
In Openstack API it's a simple openstack subnet set call, but it's impossible through CAPO.

Anything else you would like to add:
Currently mutable fields:

cluster-api-provider-openstack/pkg/webhooks/openstackcluster_webhook.go

Line 76 in 4142407

func (*openStackClusterWebhook) ValidateUpdate(_ context.Context, oldObjRaw, newObjRaw runtime.Object) (admission.Warnings, error) {

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 10, 2025
@lentzi90
Copy link
Contributor

This has been discussed previously here: #1603
Looks like there is agreement that this would be fine to implement but no one has stepped forward to work on it.
Would you be willing to push a PR?

Note that it will probably require a bit more than just changing the validation logic. The controller must also actually apply the changes. Current logic is probably just create/delete...

@pbasov pbasov linked a pull request Apr 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
CAPO Roadmap
Status: Inbox
Milestone
No milestone
3 participants
@pbasov @lentzi90 @k8s-ci-robot