Merge pull request #1803 from shiftstack/create-instance-nil

k8s-ci-robot · web-flow · commit e590271d912d · 2023-12-22T09:29:46.000+01:00
🐛 Fix potential panic during instance create
diff --git a/pkg/cloud/services/compute/instance.go b/pkg/cloud/services/compute/instance.go
@@ -348,7 +348,7 @@ func (s *Service) createInstanceImpl(eventObject runtime.Object, openStackCluste
 		return createdInstance.State() == infrav1.InstanceStateActive, nil
 	})
 	if err != nil {
-		record.Warnf(eventObject, "FailedCreateServer", "Failed to create server %s: %v", createdInstance.Name(), err)
+		record.Warnf(eventObject, "FailedCreateServer", "Failed to create server %s: %v", instanceSpec.Name, err)
 		return nil, err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ func (s *Service) createInstanceImpl(eventObject runtime.Object, openStackCluste`
`348`	`348`	`return createdInstance.State() == infrav1.InstanceStateActive, nil`
`349`	`349`	`})`
`350`	`350`	`if err != nil {`
`351`		`- record.Warnf(eventObject, "FailedCreateServer", "Failed to create server %s: %v", createdInstance.Name(), err)`
	`351`	`+ record.Warnf(eventObject, "FailedCreateServer", "Failed to create server %s: %v", instanceSpec.Name, err)`
`352`	`352`	`return nil, err`
`353`	`353`	`}`
`354`	`354`