Skip to content

Commit d5f5101

Browse files
authored
Merge pull request #1760 from shiftstack/dockerfile
🌱 Remove Containerfile and Dockerfile experimental
2 parents 141013b + 89e56a4 commit d5f5101

File tree

5 files changed

+3
-84
lines changed

5 files changed

+3
-84
lines changed

Containerfile

Lines changed: 0 additions & 61 deletions
This file was deleted.

Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
# syntax=docker/dockerfile:1.1-experimental
2-
3-
# Copyright 2019 The Kubernetes Authors.
1+
# Copyright 2023 The Kubernetes Authors.
42
#
53
# Licensed under the Apache License, Version 2.0 (the "License");
64
# you may not use this file except in compliance with the License.

Makefile

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,6 @@ export KUBEBUILDER_CONTROLPLANE_STOP_TIMEOUT ?= 60s
6060

6161
PATH := $(abspath $(TOOLS_BIN_DIR)):$(PATH)
6262
export PATH
63-
export DOCKER_CLI_EXPERIMENTAL=enabled
64-
export DOCKER_BUILDKIT=1
65-
66-
PODMAN ?= 0
67-
ifeq ($(PODMAN), 1)
68-
CONTAINERFILE ?= Containerfile
69-
else
70-
CONTAINERFILE ?= Dockerfile
71-
endif
7263

7364
# Release variables
7465

@@ -289,19 +280,13 @@ generate-manifests: $(CONTROLLER_GEN) ## Generate manifests e.g. CRD, RBAC etc.
289280
## --------------------------------------
290281

291282
.PHONY: docker-build
292-
docker-build: docker-pull-prerequisites ## Build the docker image for controller-manager
293-
docker build -f $(CONTAINERFILE) --build-arg goproxy=$(GOPROXY) --build-arg ARCH=$(ARCH) --build-arg LDFLAGS="$(LDFLAGS)" . -t $(CONTROLLER_IMG_TAG)
283+
docker-build: ## Build the docker image for controller-manager
284+
docker build -f Dockerfile --build-arg goproxy=$(GOPROXY) --build-arg ARCH=$(ARCH) --build-arg LDFLAGS="$(LDFLAGS)" . -t $(CONTROLLER_IMG_TAG)
294285

295286
.PHONY: docker-push
296287
docker-push: ## Push the docker image
297288
docker push $(CONTROLLER_IMG_TAG)
298289

299-
.PHONY: docker-pull-prerequisites
300-
docker-pull-prerequisites:
301-
[ "$(PODMAN)" -eq 0 ] && docker pull docker.io/docker/dockerfile:1.1-experimental
302-
docker pull docker.io/library/golang:$(GOLANG_VERSION)
303-
docker pull gcr.io/distroless/static:latest
304-
305290
## --------------------------------------
306291
##@ Docker — All ARCH
307292
## --------------------------------------

hack/boilerplate/boilerplate.Dockerfile.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# syntax=docker/dockerfile:1.1-experimental
2-
31
# Copyright YEAR The Kubernetes Authors.
42
#
53
# Licensed under the Apache License, Version 2.0 (the "License");

versions.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@
1313
# limitations under the License.
1414

1515
MDBOOK_VERSION := v0.4.5
16-
GOLANG_VERSION := 1.20.10
1716
PLANTUML_VERSION := 1.2022.6
1817
GH_VERSION := 1.2.0

0 commit comments

Comments
 (0)