Fix returning non-empty reconcile result and error

Author: EmilienM

controllers/openstackcluster_controller.go

@@ -121,11 +121,20 @@ func (r *OpenStackClusterReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 	// Handle deleted clusters
 	if !openStackCluster.DeletionTimestamp.IsZero() {
-		return r.reconcileDelete(ctx, scope, cluster, openStackCluster)
+		result, err := r.reconcileDelete(ctx, scope, cluster, openStackCluster)
+		if err != nil {
+			return reconcile.Result{}, err
+		}
+		return result, nil
 	}
 
 	// Handle non-deleted clusters
-	return reconcileNormal(scope, cluster, openStackCluster)
+	result, err := reconcileNormal(scope, cluster, openStackCluster)
+	if err != nil {
+		return reconcile.Result{}, err
+	}
+
+	return result, nil
 }
 
 func (r *OpenStackClusterReconciler) reconcileDelete(ctx context.Context, scope scope.Scope, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster) (ctrl.Result, error) {
@@ -297,8 +306,11 @@ func reconcileNormal(scope scope.Scope, cluster *clusterv1.Cluster, openStackClu
 	}
 
 	result, err := reconcileBastion(scope, cluster, openStackCluster)
-	if err != nil || !reflect.DeepEqual(result, reconcile.Result{}) {
-		return result, err
+	if err != nil {
+		return reconcile.Result{}, err
+	}
+	if !result.IsZero() {
+		return result, nil
 	}
 
 	availabilityZones, err := computeService.GetAvailabilityZones()

controllers/openstackmachine_controller.go

@@ -158,7 +158,11 @@ func (r *OpenStackMachineReconciler) Reconcile(ctx context.Context, req ctrl.Req
 	}
 
 	// Handle non-deleted clusters
-	return r.reconcileNormal(ctx, scope, cluster, infraCluster, machine, openStackMachine)
+	result, err := r.reconcileNormal(ctx, scope, cluster, infraCluster, machine, openStackMachine)
+	if err != nil {
+		return reconcile.Result{}, err
+	}
+	return result, nil
 }
 
 func patchMachine(ctx context.Context, patchHelper *patch.Helper, openStackMachine *infrav1.OpenStackMachine, machine *clusterv1.Machine, options ...patch.Option) error {