Merge pull request #1202 from anilkumar56/improve_log

k8s-ci-robot · web-flow · commit c3d843f74857 · 2022-04-21T06:34:57.000-07:00
Improve log message
diff --git a/controllers/openstackmachine_controller.go b/controllers/openstackmachine_controller.go
@@ -272,7 +272,7 @@ func (r *OpenStackMachineReconciler) reconcileDelete(ctx context.Context, scope
 func (r *OpenStackMachineReconciler) reconcileNormal(ctx context.Context, scope *scope.Scope, patchHelper *patch.Helper, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster, machine *clusterv1.Machine, openStackMachine *infrav1.OpenStackMachine) (_ ctrl.Result, reterr error) {
 	// If the OpenStackMachine is in an error state, return early.
 	if openStackMachine.Status.FailureReason != nil || openStackMachine.Status.FailureMessage != nil {
-		scope.Logger.Info("Error state detected, skipping reconciliation")
+		scope.Logger.Info("Not reconciling machine in failed state. See openStackMachine.status.failureReason, openStackMachine.status.failureMessage, or previously logged error for details")
 		return ctrl.Result{}, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ func (r *OpenStackMachineReconciler) reconcileDelete(ctx context.Context, scope`
`272`	`272`	`func (r OpenStackMachineReconciler) reconcileNormal(ctx context.Context, scope scope.Scope, patchHelper patch.Helper, cluster clusterv1.Cluster, openStackCluster infrav1.OpenStackCluster, machine clusterv1.Machine, openStackMachine *infrav1.OpenStackMachine) (_ ctrl.Result, reterr error) {`
`273`	`273`	`// If the OpenStackMachine is in an error state, return early.`
`274`	`274`	`if openStackMachine.Status.FailureReason != nil \|\| openStackMachine.Status.FailureMessage != nil {`
`275`		`- scope.Logger.Info("Error state detected, skipping reconciliation")`
	`275`	`+ scope.Logger.Info("Not reconciling machine in failed state. See openStackMachine.status.failureReason, openStackMachine.status.failureMessage, or previously logged error for details")`
`276`	`276`	`return ctrl.Result{}, nil`
`277`	`277`	`}`
`278`	`278`