Skip to content

Commit c0b54d0

Browse files
authored
Merge pull request #1911 from shiftstack/conversion-gen
🌱 Enhancements to how controller-gen is invoked
2 parents 634ccc7 + 4bb8966 commit c0b54d0

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

Makefile

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -245,25 +245,28 @@ modules: ## Runs go mod to ensure proper vendoring.
245245
cd $(TOOLS_DIR); go mod tidy
246246

247247
.PHONY: generate
248-
generate: ## Generate code
249-
$(MAKE) generate-go
250-
$(MAKE) generate-manifests
248+
generate: generate-controller-gen generate-conversion-gen generate-go generate-manifests ## Generate all generated code
251249

252250
.PHONY: generate-go
253251
generate-go: $(MOCKGEN)
254-
$(MAKE) -B $(CONTROLLER_GEN) $(CONVERSION_GEN)
252+
go generate ./...
253+
254+
.PHONY: generate-controller-gen
255+
generate-controller-gen: $(CONTROLLER_GEN)
255256
$(CONTROLLER_GEN) \
256257
paths=./api/... \
257258
object:headerFile=./hack/boilerplate/boilerplate.generatego.txt
259+
260+
.PHONY: generate-conversion-gen
261+
capo_module := sigs.k8s.io/cluster-api-provider-openstack
262+
generate-conversion-gen: $(CONVERSION_GEN)
258263
$(CONVERSION_GEN) \
259-
--input-dirs=./api/v1alpha1 \
260-
--input-dirs=./api/v1alpha5 \
261-
--input-dirs=./api/v1alpha6 \
262-
--input-dirs=./api/v1alpha7 \
263-
--input-dirs=./api/v1beta1 \
264+
--input-dirs=$(capo_module)/api/v1alpha5 \
265+
--input-dirs=$(capo_module)/api/v1alpha6 \
266+
--input-dirs=$(capo_module)/api/v1alpha7 \
264267
--output-file-base=zz_generated.conversion \
268+
--trim-path-prefix=$(capo_module)/ \
265269
--go-header-file=./hack/boilerplate/boilerplate.generatego.txt
266-
go generate ./...
267270

268271
.PHONY: generate-manifests
269272
generate-manifests: $(CONTROLLER_GEN) ## Generate manifests e.g. CRD, RBAC etc.

0 commit comments

Comments
 (0)