Add tests + pointer checks

Author: EmilienM

pkg/cloud/services/loadbalancer/loadbalancer.go

@@ -143,7 +143,7 @@ func (s *Service) ReconcileLoadBalancer(openStackCluster *infrav1.OpenStackClust
 func getAPIServerVIPAddress(openStackCluster *infrav1.OpenStackCluster) (string, error) {
 	switch {
 	// We only use call this function when creating the loadbalancer, so this case should never be used
-	case openStackCluster.Status.APIServerLoadBalancer.InternalIP != "":
+	case openStackCluster.Status.APIServerLoadBalancer != nil && openStackCluster.Status.APIServerLoadBalancer.InternalIP != "":
 		return openStackCluster.Status.APIServerLoadBalancer.InternalIP, nil
 
 	// Explicit fixed IP in the cluster spec
@@ -167,7 +167,7 @@ func getAPIServerVIPAddress(openStackCluster *infrav1.OpenStackCluster) (string,
 func getAPIServerFloatingIP(openStackCluster *infrav1.OpenStackCluster) (string, error) {
 	switch {
 	// The floating IP was created previously
-	case openStackCluster.Status.APIServerLoadBalancer.IP != "":
+	case openStackCluster.Status.APIServerLoadBalancer != nil && openStackCluster.Status.APIServerLoadBalancer.IP != "":
 		return openStackCluster.Status.APIServerLoadBalancer.IP, nil
 
 	// Explicit floating IP in the cluster spec
@@ -214,7 +214,7 @@ func getCanonicalAllowedCIDRs(openStackCluster *infrav1.OpenStackCluster) []stri
 				}
 			}
 
-			if len(openStackCluster.Status.Router.IPs) > 0 {
+			if openStackCluster.Status.Router != nil && len(openStackCluster.Status.Router.IPs) > 0 {
 				allowedCIDRs = append(allowedCIDRs, openStackCluster.Status.Router.IPs...)
 			}
 		}
@@ -260,6 +260,10 @@ func (s *Service) getOrCreateAPILoadBalancer(openStackCluster *infrav1.OpenStack
 		return lb, nil
 	}
 
+	if openStackCluster.Status.Network == nil {
+		return nil, fmt.Errorf("network is not yet available in OpenStackCluster.Status")
+	}
+
 	// Create the VIP on the first cluster subnet
 	subnetID := openStackCluster.Status.Network.Subnets[0].ID
 	s.scope.Logger().Info("Creating load balancer in subnet", "subnetID", subnetID, "name", loadBalancerName)
@@ -312,6 +316,10 @@ func (s *Service) reconcileAPILoadBalancerListener(lb *loadbalancers.LoadBalance
 	loadBalancerName := getLoadBalancerName(clusterName)
 	lbPortObjectsName := fmt.Sprintf("%s-%d", loadBalancerName, port)
 
+	if openStackCluster.Status.APIServerLoadBalancer == nil {
+		return fmt.Errorf("APIServerLoadBalancer is not yet available in OpenStackCluster.Status")
+	}
+
 	allowedCIDRs := openStackCluster.Status.APIServerLoadBalancer.AllowedCIDRs
 
 	listener, err := s.getOrCreateListener(openStackCluster, lbPortObjectsName, lb.ID, allowedCIDRs, port)