Merge pull request #1268 from jichenjc/update_event

k8s-ci-robot · web-flow · commit 7a8c2e82b58c · 2022-06-21T17:39:43.000-07:00
nit:make event to log for already associated FIP
diff --git a/pkg/cloud/services/networking/floatingip.go b/pkg/cloud/services/networking/floatingip.go
@@ -123,7 +123,7 @@ func (s *Service) AssociateFloatingIP(eventObject runtime.Object, fp *floatingip
 	s.scope.Logger.Info("Associating floating IP", "id", fp.ID, "ip", fp.FloatingIP)
 
 	if fp.PortID == portID {
-		record.Eventf(eventObject, "SuccessfulAssociateFloatingIP", "Floating IP %s already associated with port %s", fp.FloatingIP, portID)
+		s.scope.Logger.Info("Floating IP already associated:", "id", fp.ID, "ip", fp.FloatingIP)
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ func (s Service) AssociateFloatingIP(eventObject runtime.Object, fp floatingip`
`123`	`123`	`s.scope.Logger.Info("Associating floating IP", "id", fp.ID, "ip", fp.FloatingIP)`
`124`	`124`
`125`	`125`	`if fp.PortID == portID {`
`126`		`- record.Eventf(eventObject, "SuccessfulAssociateFloatingIP", "Floating IP %s already associated with port %s", fp.FloatingIP, portID)`
	`126`	`+ s.scope.Logger.Info("Floating IP already associated:", "id", fp.ID, "ip", fp.FloatingIP)`
`127`	`127`	`return nil`
`128`	`128`	`}`
`129`	`129`