Skip to content

Commit 4bd8348

Browse files
committed
Fix returning non-empty reconcile result and error
1 parent 5d62dd5 commit 4bd8348

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

controllers/openstackcluster_controller.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,12 @@ func (r *OpenStackClusterReconciler) Reconcile(ctx context.Context, req ctrl.Req
125125
}
126126

127127
// Handle non-deleted clusters
128-
return reconcileNormal(scope, cluster, openStackCluster)
128+
result, err := reconcileNormal(scope, cluster, openStackCluster)
129+
if err != nil {
130+
return reconcile.Result{}, err
131+
}
132+
133+
return result, nil
129134
}
130135

131136
func (r *OpenStackClusterReconciler) reconcileDelete(ctx context.Context, scope scope.Scope, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster) (ctrl.Result, error) {
@@ -297,8 +302,11 @@ func reconcileNormal(scope scope.Scope, cluster *clusterv1.Cluster, openStackClu
297302
}
298303

299304
result, err := reconcileBastion(scope, cluster, openStackCluster)
300-
if err != nil || !reflect.DeepEqual(result, reconcile.Result{}) {
301-
return result, err
305+
if err != nil {
306+
return reconcile.Result{}, err
307+
}
308+
if !reflect.DeepEqual(result, reconcile.Result{}) {
309+
return result, nil
302310
}
303311

304312
availabilityZones, err := computeService.GetAvailabilityZones()

controllers/openstackmachine_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,11 @@ func (r *OpenStackMachineReconciler) Reconcile(ctx context.Context, req ctrl.Req
158158
}
159159

160160
// Handle non-deleted clusters
161-
return r.reconcileNormal(ctx, scope, cluster, infraCluster, machine, openStackMachine)
161+
result, err := r.reconcileNormal(ctx, scope, cluster, infraCluster, machine, openStackMachine)
162+
if err != nil {
163+
return reconcile.Result{}, err
164+
}
165+
return result, nil
162166
}
163167

164168
func patchMachine(ctx context.Context, patchHelper *patch.Helper, openStackMachine *infrav1.OpenStackMachine, machine *clusterv1.Machine, options ...patch.Option) error {

0 commit comments

Comments
 (0)