Merge pull request #1276 from jichenjc/bug/1265

not assign floating ip when there are multiple controller nodes

Author: k8s-ci-robot

controllers/openstackmachine_controller.go

@@ -359,29 +359,37 @@ func (r *OpenStackMachineReconciler) reconcileNormal(ctx context.Context, scope
 		return ctrl.Result{RequeueAfter: waitForInstanceBecomeActiveToReconcile}, nil
 	}
 
-	if util.IsControlPlaneMachine(machine) {
-		if openStackCluster.Spec.APIServerLoadBalancer.Enabled {
-			err = r.reconcileLoadBalancerMember(scope, openStackCluster, machine, openStackMachine, instanceNS, clusterName)
-			if err != nil {
-				handleUpdateMachineError(scope.Logger, openStackMachine, errors.Errorf("LoadBalancerMember cannot be reconciled: %v", err))
-				return ctrl.Result{}, nil
-			}
-		} else if !openStackCluster.Spec.DisableAPIServerFloatingIP {
-			floatingIPAddress := openStackCluster.Spec.ControlPlaneEndpoint.Host
-			if openStackCluster.Spec.APIServerFloatingIP != "" {
-				floatingIPAddress = openStackCluster.Spec.APIServerFloatingIP
-			}
-			fp, err := networkingService.GetOrCreateFloatingIP(openStackMachine, openStackCluster, clusterName, floatingIPAddress)
-			if err != nil {
-				handleUpdateMachineError(scope.Logger, openStackMachine, errors.Errorf("Floating IP cannot be got or created: %v", err))
-				return ctrl.Result{}, nil
-			}
-			port, err := computeService.GetManagementPort(openStackCluster, instanceStatus)
-			if err != nil {
-				err = errors.Errorf("getting management port for control plane machine %s: %v", machine.Name, err)
-				handleUpdateMachineError(scope.Logger, openStackMachine, err)
-				return ctrl.Result{}, nil
-			}
+	if !util.IsControlPlaneMachine(machine) {
+		scope.Logger.Info("Not a Control plane machine, no floating ip reconcile needed, Reconciled Machine create successfully")
+		return ctrl.Result{}, nil
+	}
+
+	if openStackCluster.Spec.APIServerLoadBalancer.Enabled {
+		err = r.reconcileLoadBalancerMember(scope, openStackCluster, machine, openStackMachine, instanceNS, clusterName)
+		if err != nil {
+			handleUpdateMachineError(scope.Logger, openStackMachine, errors.Errorf("LoadBalancerMember cannot be reconciled: %v", err))
+			return ctrl.Result{}, nil
+		}
+	} else if !openStackCluster.Spec.DisableAPIServerFloatingIP {
+		floatingIPAddress := openStackCluster.Spec.ControlPlaneEndpoint.Host
+		if openStackCluster.Spec.APIServerFloatingIP != "" {
+			floatingIPAddress = openStackCluster.Spec.APIServerFloatingIP
+		}
+		fp, err := networkingService.GetOrCreateFloatingIP(openStackMachine, openStackCluster, clusterName, floatingIPAddress)
+		if err != nil {
+			handleUpdateMachineError(scope.Logger, openStackMachine, errors.Errorf("Floating IP cannot be got or created: %v", err))
+			return ctrl.Result{}, nil
+		}
+		port, err := computeService.GetManagementPort(openStackCluster, instanceStatus)
+		if err != nil {
+			err = errors.Errorf("getting management port for control plane machine %s: %v", machine.Name, err)
+			handleUpdateMachineError(scope.Logger, openStackMachine, err)
+			return ctrl.Result{}, nil
+		}
+
+		if len(fp.PortID) != 0 {
+			scope.Logger.Info("Floating IP already associated to a port:", "id", fp.ID, "fixed ip", fp.FixedIP, "portID", port.ID)
+		} else {
 			err = networkingService.AssociateFloatingIP(openStackMachine, fp, port.ID)
 			if err != nil {
 				handleUpdateMachineError(scope.Logger, openStackMachine, errors.Errorf("Floating IP cannot be associated: %v", err))

docs/book/src/clusteropenstack/configuration.md

@@ -153,6 +153,12 @@ openstack floating ip create <public network>
 
 Note: Only user with admin role can create a floating IP with specific IP.
 
+Note: When associating a floating IP to a cluster with more than 1 controller node, the floatingIP will be
+associated to the first controller node and the other controller nodes have no floating IP assigned. When
+ the controller node has the floating IP status down CAPO will NOT auto assign the floating IP address
+to any other controller node. So we recommend to only set one controller node when floating IP is needed,
+or please consider using load balancer instead, see [issue #1265](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1265) for further information.
+
 ### Disabling the API server floating IP
 
 It is possible to provision a cluster without a floating IP for the API server by setting