Skip to content

add email & slack notifier action in github workflow #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add email & slack notifier action in github workflow #2280

wants to merge 1 commit into from

Conversation

mohitsethia
Copy link

What this PR does / why we need it:
Adds email and slack notification workflow action template for weekly security scan.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2179

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Mar 30, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 30, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mohitsethia
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 30, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mohitsethia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 1f4a0ee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67e989557be06d0008600a96
😎 Deploy Preview https://deploy-preview-2280.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mohitsethia mohitsethia mentioned this pull request Mar 30, 2025
Open
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 30, 2025
@Prajyot-Parab
Copy link
Contributor

@anshuman-agarwala can you help validating these changes.

mkumatag
mkumatag requested changes Apr 11, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the basic Q - where do you want to report these? which slack channel? and what email id and which smtp server it uses to send the mails?

@anshuman-agarwala
Copy link
Contributor

We can't use k8s slack since they don't give out webhook links for their channels. For the email, I think on a job failure Github sends out an email already, not sure how useful sending an email notification will be.

@mkumatag
Copy link
Member

We can't use k8s slack since they don't give out webhook links for their channels. For the email, I think on a job failure Github sends out an email already, not sure how useful sending an email notification will be.

Hmm, in that case, maybe it's not worth spending our time on this.

@mohitsethia
Copy link
Author

Is it the limitation of the slack feature for kubernetes only? Because my employers slack version provides creating webhook, maybe the admin of the k8s slack can help create one?

And I was not sure what notification was being talked about in the issue and I didn't get any response so I went ahead giving an example of both the both slack and email action workflows. I guess github only emails to the person who raised the PR and not the maintainers/contributor/whoever wants to receive the notification, but not sure how that works for k8s workgroup.

@anshuman-agarwala
Copy link
Contributor

Is it the limitation of the slack feature for kubernetes only? Because my employers slack version provides creating webhook, maybe the admin of the k8s slack can help create one?

And I was not sure what notification was being talked about in the issue and I didn't get any response so I went ahead giving an example of both the both slack and email action workflows. I guess github only emails to the person who raised the PR and not the maintainers/contributor/whoever wants to receive the notification, but not sure how that works for k8s workgroup.

It's a limitation placed on us by the kubernetes slack admins: https://github.com/kubernetes/community/blob/master/communication/slack-guidelines.md#requesting-a-bot-token-or-webhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag requested changes

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore on setting up notifications for weekly security scan
5 participants
@mohitsethia @k8s-ci-robot @Prajyot-Parab @anshuman-agarwala @mkumatag