Skip to content

Standerdise the controller workflow #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
Karthik-K-N opened this issue Jan 10, 2025 · 6 comments
Open
2 of 5 tasks

Standerdise the controller workflow #2129

Karthik-K-N opened this issue Jan 10, 2025 · 6 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@Karthik-K-N
Copy link
Contributor

Karthik-K-N commented Jan 10, 2025

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

CAPI has now updated to contain many more helper functions which can be used in our controller to make it more standard and more readable, There are helper functions to add finalisers, to verify if the resource is paused or not and many more.
Reference to one of the controller from CAPI: cluster controller

May be we should spend some time to clean up our controller logic and make the workflow standard across various controller.

  1. Pass context to calling functions to derive logger.
  2. Use CAPI provided helper functions.
  3. Adopt CAPI v1beta2 changes.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jan 10, 2025
@carmal891
Copy link
Contributor

/assign

@Karthik-K-N
Copy link
Contributor Author

I am working on IBMPowerVSMachine controller changes along improving status of IBMPowerVSMachine object with #2264

@Prajyot-Parab
Copy link
Contributor

@Karthik-K-N feel free to close this and cover it as part of overall enhancement issue that you created. (as discussed in community meeting)

@Karthik-K-N
Copy link
Contributor Author

I just converted this issue as template issue and tracks all the other subsequent pending work

@Prajyot-Parab
Copy link
Contributor

/unassign @carmal891

@Prajyot-Parab
Copy link
Contributor

/assign @Karthik-K-N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants