Refactor IsPowerVSZoneSupportsPER() code to use interface (#1775)

* Refactor IsPowerVSZoneSupportsPER() code to use interface

* Addressed review comments to sort import order

* Rename the function name

Author: Shilpa-Gokul

cloud/scope/powervs_cluster.go

@@ -25,7 +25,6 @@ import (
 	"github.com/go-logr/logr"
 
 	"github.com/IBM-Cloud/power-go-client/ibmpisession"
-	"github.com/IBM-Cloud/power-go-client/power/client/datacenters"
 	"github.com/IBM-Cloud/power-go-client/power/models"
 	"github.com/IBM/go-sdk-core/v5/core"
 	"github.com/IBM/ibm-cos-sdk-go/aws"
@@ -593,17 +592,12 @@ func (s *PowerVSClusterScope) IsPowerVSZoneSupportsPER() error {
 		return fmt.Errorf("powervs zone is not set")
 	}
 	// fetch the datacenter capabilities for zone.
-	// though the function name is WithDatacenterRegion it takes zone as parameter
-	params := datacenters.NewV1DatacentersGetParamsWithContext(context.TODO()).WithDatacenterRegion(*zone)
-	datacenter, err := s.session.Power.Datacenters.V1DatacentersGet(params)
+	datacenterCapabilities, err := s.IBMPowerVSClient.GetDatacenterCapabilities(*zone)
 	if err != nil {
-		return fmt.Errorf("failed to get datacenter details for zone: %s err:%w", *zone, err)
-	}
-	if datacenter == nil || datacenter.Payload == nil || datacenter.Payload.Capabilities == nil {
-		return fmt.Errorf("failed to get datacenter capabilities for zone: %s", *zone)
+		return err
 	}
 	// check for the PER support in datacenter capabilities.
-	perAvailable, ok := datacenter.Payload.Capabilities[powerEdgeRouter]
+	perAvailable, ok := datacenterCapabilities[powerEdgeRouter]
 	if !ok {
 		return fmt.Errorf("%s capability unknown for zone: %s", powerEdgeRouter, *zone)
 	}

pkg/cloud/services/powervs/mock/powervs_generated.go

@@ -44,4 +44,5 @@ type PowerVS interface {
 	DeleteDHCPServer(id string) error
 	WithClients(options ServiceOptions) *Service
 	GetNetworkByName(networkName string) (*models.NetworkReference, error)
+	GetDatacenterCapabilities(zone string) (map[string]bool, error)
 }

pkg/cloud/services/powervs/powervs.go

@@ -18,9 +18,11 @@ package powervs
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/IBM-Cloud/power-go-client/clients/instance"
 	"github.com/IBM-Cloud/power-go-client/ibmpisession"
+	"github.com/IBM-Cloud/power-go-client/power/client/datacenters"
 	"github.com/IBM-Cloud/power-go-client/power/client/p_cloud_images"
 	"github.com/IBM-Cloud/power-go-client/power/models"
 
@@ -185,3 +187,17 @@ func (s *Service) GetNetworkByName(networkName string) (*models.NetworkReference
 
 	return network, nil
 }
+
+// GetDatacenterCapabilities fetches the datacenter capabilities for the given zone.
+func (s *Service) GetDatacenterCapabilities(zone string) (map[string]bool, error) {
+	// though the function name is WithDatacenterRegion it takes zone as parameter
+	params := datacenters.NewV1DatacentersGetParamsWithContext(context.TODO()).WithDatacenterRegion(zone)
+	datacenter, err := s.session.Power.Datacenters.V1DatacentersGet(params)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get datacenter details for zone: %s err:%w", zone, err)
+	}
+	if datacenter == nil || datacenter.Payload == nil || datacenter.Payload.Capabilities == nil {
+		return nil, fmt.Errorf("failed to get datacenter capabilities for zone: %s", zone)
+	}
+	return datacenter.Payload.Capabilities, nil
+}