Skip to content

Commit 0ff2802

Browse files
committed
Addressed review comments
1 parent 06a797e commit 0ff2802

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

cloud/scope/powervs_cluster_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1726,7 +1726,6 @@ func TestIsDHCPServerActive(t *testing.T) {
17261726
g := NewWithT(t)
17271727
setup(t)
17281728
t.Cleanup(teardown)
1729-
// TODO: check why Status is checked here instead of spec?
17301729
clusterScope := PowerVSClusterScope{
17311730
IBMPowerVSClient: mockPowerVS,
17321731
IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{Status: infrav1beta2.IBMPowerVSClusterStatus{DHCPServer: &infrav1beta2.ResourceReference{ID: ptr.To("dhcpID")}}},
@@ -1777,22 +1776,22 @@ func TestCheckDHCPServerStatus(t *testing.T) {
17771776
expectedStatus bool
17781777
}{
17791778
{
1780-
name: "test DHCP server state build",
1779+
name: "DHCP server is in build state",
17811780
dhcpServer: models.DHCPServerDetail{ID: ptr.To("dhcpIDBuild"), Status: ptr.To(string(infrav1beta2.DHCPServerStateBuild))},
17821781
expectedStatus: false,
17831782
},
17841783
{
1785-
name: "test DHCP server state active",
1784+
name: "DHCP server is in active state",
17861785
dhcpServer: models.DHCPServerDetail{ID: ptr.To("dhcpIDActive"), Status: ptr.To(string(infrav1beta2.DHCPServerStateActive))},
17871786
expectedStatus: true,
17881787
},
17891788
{
1790-
name: "test DHCP server state error",
1789+
name: "DHCP server is in error state",
17911790
dhcpServer: models.DHCPServerDetail{ID: ptr.To("dhcpIDError"), Status: ptr.To(string(infrav1beta2.DHCPServerStateError))},
17921791
expectedStatus: false,
17931792
},
17941793
{
1795-
name: "test DHCP server state invalid value",
1794+
name: "DHCP server is in invalid state",
17961795
dhcpServer: models.DHCPServerDetail{ID: ptr.To("dhcpIDError"), Status: ptr.To("InvalidState")},
17971796
expectedStatus: false,
17981797
},

0 commit comments

Comments
 (0)