@@ -1726,7 +1726,6 @@ func TestIsDHCPServerActive(t *testing.T) {
1726
1726
g := NewWithT (t )
1727
1727
setup (t )
1728
1728
t .Cleanup (teardown )
1729
- // TODO: check why Status is checked here instead of spec?
1730
1729
clusterScope := PowerVSClusterScope {
1731
1730
IBMPowerVSClient : mockPowerVS ,
1732
1731
IBMPowerVSCluster : & infrav1beta2.IBMPowerVSCluster {Status : infrav1beta2.IBMPowerVSClusterStatus {DHCPServer : & infrav1beta2.ResourceReference {ID : ptr .To ("dhcpID" )}}},
@@ -1777,22 +1776,22 @@ func TestCheckDHCPServerStatus(t *testing.T) {
1777
1776
expectedStatus bool
1778
1777
}{
1779
1778
{
1780
- name : "test DHCP server state build" ,
1779
+ name : "DHCP server is in build state " ,
1781
1780
dhcpServer : models.DHCPServerDetail {ID : ptr .To ("dhcpIDBuild" ), Status : ptr .To (string (infrav1beta2 .DHCPServerStateBuild ))},
1782
1781
expectedStatus : false ,
1783
1782
},
1784
1783
{
1785
- name : "test DHCP server state active" ,
1784
+ name : "DHCP server is in active state " ,
1786
1785
dhcpServer : models.DHCPServerDetail {ID : ptr .To ("dhcpIDActive" ), Status : ptr .To (string (infrav1beta2 .DHCPServerStateActive ))},
1787
1786
expectedStatus : true ,
1788
1787
},
1789
1788
{
1790
- name : "test DHCP server state error" ,
1789
+ name : "DHCP server is in error state " ,
1791
1790
dhcpServer : models.DHCPServerDetail {ID : ptr .To ("dhcpIDError" ), Status : ptr .To (string (infrav1beta2 .DHCPServerStateError ))},
1792
1791
expectedStatus : false ,
1793
1792
},
1794
1793
{
1795
- name : "test DHCP server state invalid value " ,
1794
+ name : "DHCP server is in invalid state " ,
1796
1795
dhcpServer : models.DHCPServerDetail {ID : ptr .To ("dhcpIDError" ), Status : ptr .To ("InvalidState" )},
1797
1796
expectedStatus : false ,
1798
1797
},
0 commit comments