Skip to content

Additional ObjectMeta field should be removed from CloudStackMachineTemplate #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vignesh-goutham opened this issue May 5, 2023 · 3 comments
Closed

Additional ObjectMeta field should be removed from CloudStackMachineTemplate #237

vignesh-goutham opened this issue May 5, 2023 · 3 comments
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vignesh-goutham
Copy link
Contributor

vignesh-goutham commented May 5, 2023 •
edited
Loading

CloudStackMachineTemplate API for v1beta2 has an additional ObjectMeta in one of its children structs (CloudStackMachineTemplateResource. This field is not required and is not used anywhere. While this is predominately non-intrusive, kube-apiserver from 1.25 enabled ServerSideValidation as the feature matured to beta. When unmarshalling a struct from this API, in includes creationtimestamp as nil as part of that additional ObjectMeta field. A yaml generated from un-marshalling struct fails server side validation.

API field to be removed -

cluster-api-provider-cloudstack/api/v1beta2/cloudstackmachinetemplate_types.go

Line 28 in 8c69f07

ObjectMeta metav1.ObjectMeta `json:"metadata,omitempty"`

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 5, 2023
@vignesh-goutham
Copy link
Contributor Author

/kind bug
/kind api-change

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 5, 2023
@vignesh-goutham vignesh-goutham mentioned this issue Jun 12, 2023
Merged
@hrak
Copy link
Contributor

hrak commented Sep 26, 2023

@rohityadavcloud i guess this can be closed since the linked PR is merged

@rohityadavcloud
Copy link
Member

Closing on @hrak 's comment.

@hrak hrak mentioned this issue Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rohityadavcloud @hrak @k8s-ci-robot @vignesh-goutham