add explicit metrics bind addr arg that Tilt and e2e can replace

Signed-off-by: Hans Rakers <[email protected]>

Author: hrak

config/manager/manager.yaml

@@ -21,9 +21,10 @@ spec:
       - command:
         - /manager
         args:
-        - --leader-elect
-        - --cloudstackcluster-concurrency=${CAPC_CLOUDSTACKCLUSTER_CONCURRENCY:=10}
-        - --cloudstackmachine-concurrency=${CAPC_CLOUDSTACKMACHINE_CONCURRENCY:=10}
+        - "--leader-elect"
+        - "--metrics-bind-addr=localhost:8080"
+        - "--cloudstackcluster-concurrency=${CAPC_CLOUDSTACKCLUSTER_CONCURRENCY:=10}"
+        - "--cloudstackmachine-concurrency=${CAPC_CLOUDSTACKMACHINE_CONCURRENCY:=10}"
         image: controller:latest
         name: manager
         securityContext:

test/e2e/config/cloudstack.yaml

@@ -105,8 +105,6 @@ providers:
         replacements:
           - old: --metrics-bind-addr=localhost:8080
             new: --metrics-bind-addr=:8080
-          - old: "--leader-elect"
-            new: "--leader-elect\n        - --metrics-bind-addr=:8080"
 
 variables:
   KUBERNETES_VERSION_MANAGEMENT: "v1.25.3"