Skip to content

Commit 1771844

Browse files
committed
Stop swallowing VM deployment errors
1 parent a2e323a commit 1771844

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pkg/cloud/instance.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,13 @@ func (c *client) DeployVM(
343343

344344
csMachine.Spec.InstanceID = pointer.String(vm.Id)
345345
csMachine.Status.InstanceState = vm.State
346-
} else {
347-
csMachine.Spec.InstanceID = pointer.String(deployVMResp.Id)
348-
csMachine.Status.Status = pointer.String(metav1.StatusSuccess)
346+
347+
return fmt.Errorf("incomplete vm deployment (vm_id=%v): %w", vm.Id, err)
349348
}
349+
350+
csMachine.Spec.InstanceID = pointer.String(deployVMResp.Id)
351+
csMachine.Status.Status = pointer.String(metav1.StatusSuccess)
352+
350353
return nil
351354
}
352355

0 commit comments

Comments
 (0)