Skip to content

Remove deprecated admission interfaces from API types #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nrb opened this issue Mar 28, 2025 · 3 comments · May be fixed by #5447
Open

Remove deprecated admission interfaces from API types #5450

nrb opened this issue Mar 28, 2025 · 3 comments · May be fixed by #5447
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nrb
Copy link
Contributor

nrb commented Mar 28, 2025

controller-runtime has removed the admission.Defaulter and admission.Validator interfaces as of v0.20.0 (kubernetes-sigs/controller-runtime#2877)

cluster-api v1.10 uses a version of controller-runtime that no longer has these present.

Looking through related PR history, CAPI has provided an implementer's guide for transitioning these interfaces out of API packages. https://cluster-api.sigs.k8s.io/developer/providers/getting-started/implement-api-types#registering-apis-in-the-scheme

There's also some prior art in how CAPI itself removed these here: kubernetes-sigs/cluster-api#9045
@nrb nrb added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 28, 2025
@nrb
Copy link
Contributor Author

nrb commented Mar 28, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 28, 2025
@nrb
Copy link
Contributor Author

nrb commented Mar 28, 2025

I think we'll want to tackle this independently of the CAPI bump, so we can contain the scope of the changes.

@damdo
Copy link
Member

damdo commented Apr 1, 2025

Some examples on how to do this can also be found on CAPG's PR: https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1459/files

@nrb nrb linked a pull request Apr 14, 2025 that will close this issue
🌱 Bump CAPI to v1.10.0-rc.0 #5447
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Bump CAPI to v1.10.0-rc.0 kluster-api/cluster-api-provider-aws
3 participants
@nrb @damdo @k8s-ci-robot