Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Default subnamespace permissions #317

Closed
zfrhv opened this issue Jul 17, 2023 · 4 comments
Closed

Default subnamespace permissions #317

zfrhv opened this issue Jul 17, 2023 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@zfrhv
Copy link
Contributor

zfrhv commented Jul 17, 2023

Each time when I install HNC I give permissions to the clusterRole/edit on the hnc custom resources.
It allows the clients create their own sub namespaces if they have at least edit role:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    rbac.authorization.k8s.io/aggregate-to-edit: "true"
  name: hnc-edit
rules:
- apiGroups:
  - hnc.x-k8s.io
  resources:
  - hierarchyconfigurations
  - hierarchicalresourcequotas
  - subnamespaceanchors
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - hnc.x-k8s.io
  resources:
  - hierarchicalresourcequotas
  - subnamespaceanchors
  verbs:
  - create
  - update
  - patch
  - delete

So I'm wondering, should I create a PR so it would be like that by default?

@zfrhv zfrhv changed the title Default subnamesoace permissions Default subnamespace permissions Jul 17, 2023
@erikgb
Copy link
Contributor

erikgb commented Jul 17, 2023

Yes, I think it makes sense. Maybe add permissions to the other default aggregated cluster roles (view, admin and cluster-reader) also?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 23, 2024
@zfrhv
Copy link
Contributor Author

zfrhv commented Feb 24, 2024

merged

@zfrhv zfrhv closed this as completed Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants