Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Commit 72817ff

Browse files
committed
Remove webhooks from CRDs and unbreak K8s 1.22
HNC hasn't has CRD conversion webhooks implemented since v0.6, but somehow we still had them in our CRDs. It looks like earlier versions of K8s simply ignored them but 1.22 hits internal errors if the webhooks can't be called, even though no conversion is actually occurring. Tested: can't install HNC successfully on 1.22 without this change; can install successfully with it. Also, before this change, if I edit the CRDs on the server to remove the conversion webhooks, HNC starts working.
1 parent f38224b commit 72817ff

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

config/crd/kustomization.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ patchesStrategicMerge:
1111
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix.
1212
# patches here are for enabling the conversion webhook for each CRD
1313
# and setting served and storage versions.
14-
- patches/webhook_in_hierarchyconfigurations.yaml
15-
- patches/webhook_in_hncconfigurations.yaml
16-
- patches/webhook_in_subnamespaceanchors.yaml
14+
# - patches/webhook_in_hierarchyconfigurations.yaml
15+
# - patches/webhook_in_hncconfigurations.yaml
16+
# - patches/webhook_in_subnamespaceanchors.yaml
1717
# +kubebuilder:scaffold:crdkustomizewebhookpatch
1818

1919
# [CERTMANAGER] To enable webhook, uncomment all the sections with [CERTMANAGER] prefix.

0 commit comments

Comments
 (0)