Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Commit e0680ab

Browse files
committed
Some fixes in the spec
1 parent cec5d74 commit e0680ab

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

Diff for: cosi.pb.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: cosi.proto

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ extend google.protobuf.ServiceOptions {
5454

5555
service Identity {
5656
// This call is meant to retrieve the unique provisioner Identity.
57-
// This identity will have to be set in BucketRequest.Provisioner field in order to invoke this specific provisioner.
57+
// This identity will have to be set in BucketClaim.DriverName field in order to invoke this specific provisioner.
5858
rpc DriverGetInfo (DriverGetInfoRequest) returns (DriverGetInfoResponse) {}
5959
}
6060

Diff for: spec.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ extend google.protobuf.ServiceOptions {
181181
182182
service Identity {
183183
// This call is meant to retrieve the unique provisioner Identity.
184-
// This identity will have to be set in BucketRequest.Provisioner field in order to invoke this specific provisioner.
184+
// This identity will have to be set in BucketClaim.DriverName field in order to invoke this specific provisioner.
185185
rpc DriverGetInfo (DriverGetInfoRequest) returns (DriverGetInfoResponse) {}
186186
}
187187
@@ -281,7 +281,7 @@ message DriverGetInfoResponse {
281281
string name = 1;
282282
}
283283
284-
message DriverCreateBucketRequest {
284+
message DriverCreateBucketRequest {
285285
// This field is REQUIRED
286286
// name specifies the name of the bucket that should be created.
287287
string name = 1;
@@ -431,7 +431,7 @@ The general flow of the success case MAY be as follows (protos illustrated in YA
431431
1. COSI system queries metadata via Identity RPC.
432432

433433
```
434-
# COSI system --(ProvisionerGetInfo)--> Plugin
434+
# COSI system --(DriverGetInfo)--> Plugin
435435
request:
436436
response:
437437
name: org.foo.whizbang.super-plugin
@@ -446,16 +446,16 @@ message DriverGetInfoResponse {
446446
}
447447
```
448448

449-
#### `ProvisionerCreateBucket`
449+
#### `DriverCreateBucket`
450450

451451
A Controller Plugin MUST implement this RPC call.
452452
This RPC will be called by the COSI system to provision a new bucket on behalf of a COSI user.
453453

454454
This operation MUST be idempotent.
455-
If a volume corresponding to the specified bucket `name` already exists, is accessible from `accessibility_requirements, and is compatible with the specified attributes of the bucket in the `ProvisionerCreateBucket`, the Plugin MUST reply `0 OK` with the corresponding `ProvisionerCreateBucketResponse`.
455+
If a volume corresponding to the specified bucket `name` already exists, is accessible from `accessibility_requirements, and is compatible with the specified attributes of the bucket in the `DriverCreateBucket`, the Plugin MUST reply `0 OK` with the corresponding `DriverCreateBucketResponse`.
456456

457457
```
458-
message ProvisionerCreateBucketRequest {
458+
message DriverCreateBucketRequest {
459459
// Idempotency - This name is generated by the COSI system to achieve
460460
// idempotency.
461461
// This field is REQUIRED.
@@ -466,7 +466,7 @@ message ProvisionerCreateBucketRequest {
466466
map<string,string> bucket_context = 2;
467467
}
468468
469-
message ProvisionerCreateBucketResponse {
469+
message DriverCreateBucketResponse {
470470
// Intentionally left blank
471471
}
472472

0 commit comments

Comments
 (0)