Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

cloudbuild: push images straight from docker build #87

Merged
merged 1 commit into from
Sep 15, 2023
Merged

cloudbuild: push images straight from docker build #87

merged 1 commit into from
Sep 15, 2023

Conversation

BlaineEXE
Copy link
Contributor

Using docker buildx build --load ... with multi arch builds returns the below error:

error: docker exporter does not currently support exporting manifest lists

Use --push instead to push images directy from the docker build. This makes the images cloudbuild step unnecessary.

@BlaineEXE
cloudbuild: push images straight from docker build
bc000d7 
Using `docker buildx build --load ...` with multi arch builds returns
the below error:
> error: docker exporter does not currently support exporting manifest lists

Use --push instead to push images directy from the docker build. This
makes the `images` cloudbuild step unnecessary.

Signed-off-by: Blaine Gardner <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from wlan0 September 14, 2023 23:46
@k8s-ci-robot
Copy link
Contributor

Hi @BlaineEXE. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
wlan0
wlan0 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@wlan0 wlan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@wlan0
Copy link
Contributor

wlan0 commented Sep 14, 2023

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9ad2990 into kubernetes-retired:master Sep 15, 2023
@BlaineEXE BlaineEXE deleted the use-push branch September 15, 2023 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlaineEXE @k8s-ci-robot @wlan0