Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

use megalinter #98

Closed
wants to merge 1 commit into from
Closed

use megalinter #98

wants to merge 1 commit into from

Conversation

BlaineEXE
Copy link
Contributor

Add megalinter config and tooling to run megalinter.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2024
@BlaineEXE BlaineEXE force-pushed the megalinter branch 5 times, most recently from 46f4bb5 to 15f2aa9 Compare September 16, 2024 21:44
@BlaineEXE
Copy link
Contributor Author

The megalinter action isn't running, and I'm not sure why. I reached out to the sig-contribex channel to see if actions need to be enabled for them to run.

I tested this by opening a PR against my fork of the repo, and it's working, so I am pretty sure that it's not an action yaml mistake. BlaineEXE#1

@BlaineEXE
use megalinter
160766d 
Add megalinter config and tooling to run megalinter.

Signed-off-by: Blaine Gardner <[email protected]>
@BlaineEXE
Copy link
Contributor Author

Based on testing in my fork, I think this is ready. From a slack thread in sig-contribex (https://kubernetes.slack.com/archives/C1TU9EB9S/p1726523381334639) we can expect the action to run after merging but not before.

@BlaineEXE BlaineEXE marked this pull request as ready for review September 18, 2024 17:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BlaineEXE BlaineEXE closed this Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mukhoakash mukhoakash Awaiting requested review from mukhoakash

@saad-ali saad-ali Awaiting requested review from saad-ali

@shanduur shanduur Awaiting requested review from shanduur

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlaineEXE @k8s-ci-robot