Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

cosi deployment docs #18

Merged
merged 1 commit into from
Feb 3, 2021
Merged

cosi deployment docs #18

merged 1 commit into from
Feb 3, 2021

Conversation

tparikh
Copy link
Contributor

@tparikh tparikh commented Jan 27, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @tparikh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2021
@rrati
Copy link

rrati commented Jan 27, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2021
@tparikh tparikh force-pushed the cosi-api-docs-crds branch from 0006e98 to fb57c33 Compare January 27, 2021 16:08
wlan0
wlan0 reviewed Jan 27, 2021
View reviewed changes
wlan0
wlan0 reviewed Jan 27, 2021
View reviewed changes
@tparikh tparikh force-pushed the cosi-api-docs-crds branch from fb57c33 to c82b268 Compare February 1, 2021 23:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2021
@tparikh tparikh changed the title cosi deployment doc for setting up CRDs cosi deployment docs Feb 1, 2021
@tparikh tparikh requested a review from wlan0 February 1, 2021 23:41
@tparikh tparikh force-pushed the cosi-api-docs-crds branch 2 times, most recently from 7ec8ed9 to 4fa53c5 Compare February 2, 2021 20:47
@tparikh tparikh force-pushed the cosi-api-docs-crds branch from 4fa53c5 to 1fff4e3 Compare February 2, 2021 20:49
@wlan0
Copy link
Contributor

wlan0 commented Feb 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2021
@wlan0
Copy link
Contributor

wlan0 commented Feb 3, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tparikh, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a8f1e9 into kubernetes-retired:master Feb 3, 2021
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request May 29, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#18 from tparikh/kustomize
449e61e 
Added Kustomize for controller, sidecar & CRDs
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#18 from tparikh/kustomize
5d7ae6e 
Added Kustomize for controller, sidecar & CRDs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YiannisGkoufas YiannisGkoufas YiannisGkoufas left review comments

@wlan0 wlan0 wlan0 approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tparikh @k8s-ci-robot @rrati @wlan0 @YiannisGkoufas