Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit bdbb875

Browse files
committed
Fix : Use value for endpoint and region from driver
Signed-off-by: Jiffin Tony Thottan <[email protected]>
1 parent 2213723 commit bdbb875

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Diff for: container-object-storage-interface-provisioner-sidecar/pkg/bucketaccess/bucketaccess_controller.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ func (bal *BucketAccessListener) Add(ctx context.Context, inputBucketAccess *v1a
204204

205205
if val, ok = credentials[consts.S3Key]; ok {
206206
secretS3 := &cosiapi.SecretS3{
207-
Endpoint: "https://s3.amazonaws.com",
208-
Region: "us-west-1",
207+
Endpoint: val.Secrets[consts.S3Endpoint],
208+
Region: val.Secrets[consts.S3Region],
209209
AccessKeyID: val.Secrets[consts.S3SecretAccessKeyID],
210210
AccessSecretKey: val.Secrets[consts.S3SecretAccessSecretKey],
211211
}

Diff for: container-object-storage-interface-provisioner-sidecar/pkg/consts/consts.go

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ const (
2929
AzureKey = "azure"
3030
S3SecretAccessKeyID = "accessKeyID"
3131
S3SecretAccessSecretKey = "accessSecretKey"
32+
S3Endpoint = "endpoint"
33+
S3Region = "region"
3234
AzureSecretAccessToken = "accessToken"
3335
AzureSecretExpiryTimeStamp = "expiryTs"
3436
DefaultTimeFormat = "2006-01-02 15:04:05.999999999 -0700 MST"

0 commit comments

Comments
 (0)