Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit 8a66ded

Browse files
authored
Merge pull request #10 from brahmaroutu/remove_extracode
Removing BucketClassListener and BucketAccessClassListener
2 parents 0c3244f + e84789e commit 8a66ded

File tree

2 files changed

+0
-57
lines changed

2 files changed

+0
-57
lines changed

Diff for: controller/controller.go

-31
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,8 @@ type ObjectStorageController struct {
9292

9393
// Listeners
9494
BucketListener BucketListener
95-
BucketClassListener BucketClassListener
9695
BucketRequestListener BucketRequestListener
9796
BucketAccessListener BucketAccessListener
98-
BucketAccessClassListener BucketAccessClassListener
9997
BucketAccessRequestListener BucketAccessRequestListener
10098

10199
// leader election
@@ -466,21 +464,6 @@ func (c *ObjectStorageController) runController(ctx context.Context) {
466464
}
467465
go controllerFor("BucketRequests", &v1alpha1.BucketRequest{}, addFunc, updateFunc, deleteFunc)
468466
}
469-
if c.BucketClassListener != nil {
470-
c.BucketClassListener.InitializeKubeClient(c.kubeClient)
471-
c.BucketClassListener.InitializeBucketClient(c.bucketClient)
472-
addFunc := func(ctx context.Context, obj interface{}) error {
473-
return c.BucketClassListener.Add(ctx, obj.(*v1alpha1.BucketClass))
474-
}
475-
updateFunc := func(ctx context.Context, old interface{}, new interface{}) error {
476-
return c.BucketClassListener.Update(ctx, old.(*v1alpha1.BucketClass), new.(*v1alpha1.BucketClass))
477-
}
478-
deleteFunc := func(ctx context.Context, obj interface{}) error {
479-
return c.BucketClassListener.Delete(ctx, obj.(*v1alpha1.BucketClass))
480-
}
481-
go controllerFor("BucketClasses", &v1alpha1.BucketClass{}, addFunc, updateFunc, deleteFunc)
482-
}
483-
484467
if c.BucketAccessListener != nil {
485468
c.BucketAccessListener.InitializeKubeClient(c.kubeClient)
486469
c.BucketAccessListener.InitializeBucketClient(c.bucketClient)
@@ -509,20 +492,6 @@ func (c *ObjectStorageController) runController(ctx context.Context) {
509492
}
510493
go controllerFor("BucketAccessRequests", &v1alpha1.BucketAccessRequest{}, addFunc, updateFunc, deleteFunc)
511494
}
512-
if c.BucketAccessClassListener != nil {
513-
c.BucketAccessClassListener.InitializeKubeClient(c.kubeClient)
514-
c.BucketAccessClassListener.InitializeBucketClient(c.bucketClient)
515-
addFunc := func(ctx context.Context, obj interface{}) error {
516-
return c.BucketAccessClassListener.Add(ctx, obj.(*v1alpha1.BucketAccessClass))
517-
}
518-
updateFunc := func(ctx context.Context, old interface{}, new interface{}) error {
519-
return c.BucketAccessClassListener.Update(ctx, old.(*v1alpha1.BucketAccessClass), new.(*v1alpha1.BucketAccessClass))
520-
}
521-
deleteFunc := func(ctx context.Context, obj interface{}) error {
522-
return c.BucketAccessClassListener.Delete(ctx, obj.(*v1alpha1.BucketAccessClass))
523-
}
524-
go controllerFor("BucketAccessClasses", &v1alpha1.BucketAccessClass{}, addFunc, updateFunc, deleteFunc)
525-
}
526495

527496
<-ctx.Done()
528497
}

Diff for: controller/interfaces.go

-26
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,6 @@ func (c *ObjectStorageController) AddBucketListener(b BucketListener) {
3030
c.BucketListener = b
3131
}
3232

33-
type BucketClassListener interface {
34-
GenericListener
35-
36-
Add(ctx context.Context, b *v1alpha1.BucketClass) error
37-
Update(ctx context.Context, old *v1alpha1.BucketClass, new *v1alpha1.BucketClass) error
38-
Delete(ctx context.Context, b *v1alpha1.BucketClass) error
39-
}
40-
41-
func (c *ObjectStorageController) AddBucketClassListener(b BucketClassListener) {
42-
c.initialized = true
43-
c.BucketClassListener = b
44-
}
45-
4633
type BucketRequestListener interface {
4734
GenericListener
4835

@@ -69,19 +56,6 @@ func (c *ObjectStorageController) AddBucketAccessListener(b BucketAccessListener
6956
c.BucketAccessListener = b
7057
}
7158

72-
type BucketAccessClassListener interface {
73-
GenericListener
74-
75-
Add(ctx context.Context, b *v1alpha1.BucketAccessClass) error
76-
Update(ctx context.Context, old *v1alpha1.BucketAccessClass, new *v1alpha1.BucketAccessClass) error
77-
Delete(ctx context.Context, b *v1alpha1.BucketAccessClass) error
78-
}
79-
80-
func (c *ObjectStorageController) AddBucketAccessClassListener(b BucketAccessClassListener) {
81-
c.initialized = true
82-
c.BucketAccessClassListener = b
83-
}
84-
8559
type BucketAccessRequestListener interface {
8660
GenericListener
8761

0 commit comments

Comments
 (0)