Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit 3522b17

Browse files
author
Krish Chowdhary
committed
updates mintedsecret in bucketaccess to object reference
1 parent 83cd0d5 commit 3522b17

File tree

4 files changed

+36
-7
lines changed

4 files changed

+36
-7
lines changed

Diff for: apis/objectstorage.k8s.io/v1alpha1/openapi_generated.go

+4-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: apis/objectstorage.k8s.io/v1alpha1/types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ type BucketAccessStatus struct {
250250
Message string `json:"message,omitempty"`
251251

252252
// +optional
253-
MintedSecretName string `json:"mintedSecretName,omitempty"`
253+
MintedSecret *corev1.ObjectReference `json:"mintedSecret,omitempty"`
254254

255255
// +optional
256256
AccountID string `json:"accountID,omitempty"`

Diff for: apis/objectstorage.k8s.io/v1alpha1/zz_generated.deepcopy.go

+6-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: crds/objectstorage.k8s.io_bucketaccesses.yaml

+25-2
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,31 @@ spec:
9797
type: string
9898
message:
9999
type: string
100-
mintedSecretName:
101-
type: string
100+
mintedSecret:
101+
description: 'ObjectReference contains enough information to let you inspect or modify the referred object. --- New uses of this type are discouraged because of difficulty describing its usage when embedded in APIs. 1. Ignored fields. It includes many fields which are not generally honored. For instance, ResourceVersion and FieldPath are both very rarely valid in actual usage. 2. Invalid usage help. It is impossible to add specific help for individual usage. In most embedded usages, there are particular restrictions like, "must refer only to types A and B" or "UID not honored" or "name must be restricted". Those cannot be well described when embedded. 3. Inconsistent validation. Because the usages are different, the validation rules are different by usage, which makes it hard for users to predict what will happen. 4. The fields are both imprecise and overly precise. Kind is not a precise mapping to a URL. This can produce ambiguity during interpretation and require a REST mapping. In most cases, the dependency is on the group,resource tuple and the version of the actual struct is irrelevant. 5. We cannot easily change it. Because this type is embedded in many locations, updates to this type will affect numerous schemas. Don''t make new APIs embed an underspecified API type they do not control. Instead of using this type, create a locally provided and used type that is well-focused on your reference. For example, ServiceReferences for admission registration: https://github.com/kubernetes/api/blob/release-1.17/admissionregistration/v1/types.go#L533 .'
102+
properties:
103+
apiVersion:
104+
description: API version of the referent.
105+
type: string
106+
fieldPath:
107+
description: 'If referring to a piece of an object instead of an entire object, this string should contain a valid JSON/Go field access statement, such as desiredState.manifest.containers[2]. For example, if the object reference is to a container within a pod, this would take on a value like: "spec.containers{name}" (where "name" refers to the name of the container that triggered the event) or if no container name is specified "spec.containers[2]" (container with index 2 in this pod). This syntax is chosen only to have some well-defined way of referencing a part of an object. TODO: this design is not final and this field is subject to change in the future.'
108+
type: string
109+
kind:
110+
description: 'Kind of the referent. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
111+
type: string
112+
name:
113+
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names'
114+
type: string
115+
namespace:
116+
description: 'Namespace of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/'
117+
type: string
118+
resourceVersion:
119+
description: 'Specific resourceVersion to which this reference is made, if any. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency'
120+
type: string
121+
uid:
122+
description: 'UID of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids'
123+
type: string
124+
type: object
102125
type: object
103126
type: object
104127
served: true

0 commit comments

Comments
 (0)