Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Proposal for ControlPlane Custom Resources #7

Closed
christopherhein opened this issue Oct 27, 2020 · 7 comments · Fixed by #29
Closed

Proposal for ControlPlane Custom Resources #7

christopherhein opened this issue Oct 27, 2020 · 7 comments · Fixed by #29
Assignees
@charleszheng44
Labels
kind/design Categorizes issue or PR as related to design. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@christopherhein
Copy link
Contributor

This should cover how the all the Nested* types work together.
@christopherhein
Copy link
Contributor Author

/assign @charleszheng44

@christopherhein christopherhein mentioned this issue Oct 27, 2020
Closed
@charleszheng44 charleszheng44 mentioned this issue Nov 2, 2020
Closed
@charleszheng44 charleszheng44 mentioned this issue Nov 10, 2020
Merged
@christopherhein
Copy link
Contributor Author

/kind design

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Nov 19, 2020
@christopherhein
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 19, 2020
@vincepri
Copy link
Contributor

One little suggestion, for diagrams I'd suggest using PlantUML and reuse the build infrastructure we've got upstream https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/Makefile#L28

By running make diagrams, the directive generates all PlantUML diagrams under docs/** and places them right next to the PlantUML file, vscode also has a nice extension for it :)

@christopherhein
Copy link
Contributor Author

great idea @vincepri

@christopherhein christopherhein mentioned this issue Dec 1, 2020
Open
@christopherhein
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@christopherhein: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christopherhein christopherhein mentioned this issue Jan 26, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@charleszheng44 charleszheng44

Labels
kind/design Categorizes issue or PR as related to design. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
4 participants
@christopherhein @vincepri @charleszheng44 @k8s-ci-robot