Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

⚠️ Move controlplane.cluster.x-k8s.io components to controlplane/ #45

Closed
christopherhein opened this issue May 5, 2021 · 3 comments · Fixed by #57
Closed

⚠️ Move controlplane.cluster.x-k8s.io components to controlplane/ #45

christopherhein opened this issue May 5, 2021 · 3 comments · Fixed by #57
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@christopherhein
Copy link
Contributor

When we look at other CAPI implementations instead of using multi-group controllers they typically are deployed as independent controllers, they're even built this way, for example see kcp in controlplane/kubeadm/ in https://github.com/kubernetes-sigs/cluster-ap while the main types NestedCluster in our world live usually at the top level, eg https://github.com/kubernetes-sigs/cluster-api-provider-aws you can even see the eks controlplane is built in controlplane/eks/ https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/controlplane/eks.

We should adjust to having the 4 controlplane group's resources in controlplane/nested/ and have only the top level NestedCluster at / this will also make it easier to co-operate if we eventually transition to kcp (eg #44)

@christopherhein
Copy link
Contributor Author

/milestone v0.1.x

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone May 6, 2021
@christopherhein
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 11, 2021
@christopherhein
Copy link
Contributor Author

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants