Merge pull request #56 from zhouhao3/fix-ineffassign

k8s-ci-robot · web-flow · commit e4eb62c12e07 · 2021-05-17T09:15:30.000-07:00
fix ineffectual assignment to err
diff --git a/virtualcluster/cmd/kubectl-vc/util.go b/virtualcluster/cmd/kubectl-vc/util.go
@@ -94,6 +94,9 @@ func readFromFileOrURL(path string) ([]byte, error) {
 		defer resp.Body.Close()
 
 		yamlContent, err := ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return nil, err
+		}
 		return yamlContent, nil
 	}
 	// read from a file

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,9 @@ func readFromFileOrURL(path string) ([]byte, error) {`
`94`	`94`	`defer resp.Body.Close()`
`95`	`95`
`96`	`96`	`yamlContent, err := ioutil.ReadAll(resp.Body)`
	`97`	`+ if err != nil {`
	`98`	`+ return nil, err`
	`99`	`+ }`
`97`	`100`	`return yamlContent, nil`
`98`	`101`	`}`
`99`	`102`	`// read from a file`