Merge pull request #327 from wondywang/service-sync

 🐛 Fix servcie mutator, reset pService ClusterIPs

Author: k8s-ci-robot

virtualcluster/pkg/syncer/conversion/mutate.go

@@ -428,6 +428,7 @@ func (s *serviceMutator) Mutate(vService *v1.Service) {
 		anno[constants.LabelClusterIP] = vService.Spec.ClusterIP
 		s.pService.SetAnnotations(anno)
 		s.pService.Spec.ClusterIP = ""
+		s.pService.Spec.ClusterIPs = []string{}
 	}
 	s.pService.Spec.HealthCheckNodePort = 0
 	for i := range s.pService.Spec.Ports {

virtualcluster/pkg/syncer/resources/service/dws_test.go

@@ -47,6 +47,15 @@ func tenantService(name, namespace, uid string) *corev1.Service {
 	}
 }
 
+func applyClusterIPToService(service *corev1.Service, clusterIP string) *corev1.Service {
+	service.Spec.ClusterIP = clusterIP
+	if service.Spec.ClusterIPs == nil {
+		service.Spec.ClusterIPs = make([]string, 1)
+	}
+	service.Spec.ClusterIPs[0] = clusterIP
+	return service
+}
+
 func superService(name, namespace, uid, clusterKey string) *corev1.Service {
 	return &corev1.Service{
 		ObjectMeta: metav1.ObjectMeta{
@@ -89,6 +98,11 @@ func TestDWServiceCreation(t *testing.T) {
 			ExistingObjectInTenant:  tenantService("svc-1", "default", "12345"),
 			ExpectedCreatedServices: []string{superDefaultNSName + "/svc-1"},
 		},
+		"new service with clusterIP": {
+			ExistingObjectInSuper:   []runtime.Object{},
+			ExistingObjectInTenant:  applyClusterIPToService(tenantService("svc-1", "default", "12345"), "1.1.1.1"),
+			ExpectedCreatedServices: []string{superDefaultNSName + "/svc-1"},
+		},
 		"new service but already exists": {
 			ExistingObjectInSuper: []runtime.Object{
 				superService("svc-1", superDefaultNSName, "12345", defaultClusterKey),