Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 46153a5

Browse files
committed
Add separate lint quick/full Makefile targets.
1 parent 6092fc2 commit 46153a5

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

Makefile

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,13 @@ fmt: ## Run go fmt against code
9393
vet: ## Run go vet against code
9494
go vet ./...
9595

96-
.PHONY: golangci-lint
97-
golangci-lint: $(GOLANGCI_LINT) ## Run golangci-lint against code
98-
$(GOLANGCI_LINT) run
96+
.PHONY: lint
97+
lint: $(GOLANGCI_LINT) ## Lint quickly using `golangci-lint --fast=true`
98+
$(GOLANGCI_LINT) run -v --fast=true
99+
100+
.PHONY: lint-full
101+
lint-full: $(GOLANGCI_LINT) ## Lint thoroughly using `golangci-lint --fase=false`
102+
$(GOLANGCI_LINT) run -v --fast=false
99103

100104
.PHONY: generate
101105
generate: $(CONTROLLER_GEN) ## Generate code
@@ -113,6 +117,7 @@ generate-manifests: $(CONTROLLER_GEN) ## Generate manifests e.g. CRD, RBAC etc
113117
# Build controller-gen
114118
$(CONTROLLER_GEN): $(TOOLS_DIR)/go.mod
115119
cd $(TOOLS_DIR) && go build -o $(CONTROLLER_GEN_BIN) sigs.k8s.io/controller-tools/cmd/controller-gen
120+
116121
# Build golangci-lint
117122
$(GOLANGCI_LINT): $(TOOLS_DIR)/go.mod
118123
cd $(TOOLS_DIR) && go build -o $(GOLANGCI_LINT_BIN) github.com/golangci/golangci-lint/cmd/golangci-lint

hack/verify-golangci-lint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ set -o nounset
1919
set -o pipefail
2020

2121
# run golangci-lint
22-
make golangci-lint
22+
make lint-full

0 commit comments

Comments
 (0)