Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 23205b4

Browse files
authored
Merge pull request #220 from SataQiu/fix-20190911
code clean: controlPane -> controlPlane
2 parents 6e2b7d1 + ec37499 commit 23205b4

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

controllers/kubeadmconfig_controller_test.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ func TestKubeadmConfigReconciler_Reconcile_RequeueJoiningNodesIfControlPlaneNotI
220220
workerMachine := newWorkerMachine(cluster)
221221
workerJoinConfig := newWorkerJoinKubeadmConfig(workerMachine)
222222

223-
controlPaneMachine := newControlPlaneMachine(cluster)
224-
controlPaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPaneMachine, "control-plane-join-cfg")
223+
controlPlaneMachine := newControlPlaneMachine(cluster)
224+
controlPlaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPlaneMachine, "control-plane-join-cfg")
225225

226226
testcases := []struct {
227227
name string
@@ -246,14 +246,14 @@ func TestKubeadmConfigReconciler_Reconcile_RequeueJoiningNodesIfControlPlaneNotI
246246
name: "requeue a secondary control plane when the control plane is not yet initialized",
247247
request: ctrl.Request{
248248
NamespacedName: types.NamespacedName{
249-
Namespace: controlPaneJoinConfig.Namespace,
250-
Name: controlPaneJoinConfig.Name,
249+
Namespace: controlPlaneJoinConfig.Namespace,
250+
Name: controlPlaneJoinConfig.Name,
251251
},
252252
},
253253
objects: []runtime.Object{
254254
cluster,
255-
controlPaneMachine,
256-
controlPaneJoinConfig,
255+
controlPlaneMachine,
256+
controlPlaneJoinConfig,
257257
},
258258
},
259259
}
@@ -384,14 +384,14 @@ func TestKubeadmConfigReconciler_Reconcile_ErrorIfJoiningControlPlaneHasInvalidC
384384
cluster.Status.ControlPlaneInitialized = true
385385
cluster.Status.APIEndpoints = []clusterv1.APIEndpoint{{Host: "100.105.150.1", Port: 6443}}
386386

387-
controlPaneMachine := newControlPlaneMachine(cluster)
388-
controlPaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPaneMachine, "control-plane-join-cfg")
389-
controlPaneJoinConfig.Spec.JoinConfiguration.ControlPlane = nil // Makes controlPaneJoinConfig invalid for a control plane machine
387+
controlPlaneMachine := newControlPlaneMachine(cluster)
388+
controlPlaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPlaneMachine, "control-plane-join-cfg")
389+
controlPlaneJoinConfig.Spec.JoinConfiguration.ControlPlane = nil // Makes controlPlaneJoinConfig invalid for a control plane machine
390390

391391
objects := []runtime.Object{
392392
cluster,
393-
controlPaneMachine,
394-
controlPaneJoinConfig,
393+
controlPlaneMachine,
394+
controlPlaneJoinConfig,
395395
}
396396
myclient := fake.NewFakeClientWithScheme(setupScheme(), objects...)
397397

@@ -463,15 +463,15 @@ func TestReconcileIfJoinNodesAndControlPlaneIsReady(t *testing.T) {
463463
workerMachine := newWorkerMachine(cluster)
464464
workerJoinConfig := newWorkerJoinKubeadmConfig(workerMachine)
465465

466-
controlPaneMachine := newControlPlaneMachine(cluster)
467-
controlPaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPaneMachine, "control-plane-join-cfg")
466+
controlPlaneMachine := newControlPlaneMachine(cluster)
467+
controlPlaneJoinConfig := newControlPlaneJoinKubeadmConfig(controlPlaneMachine, "control-plane-join-cfg")
468468

469469
objects := []runtime.Object{
470470
cluster,
471471
workerMachine,
472472
workerJoinConfig,
473-
controlPaneMachine,
474-
controlPaneJoinConfig,
473+
controlPlaneMachine,
474+
controlPlaneJoinConfig,
475475
}
476476
objects = append(objects, createSecrets(t, cluster)...)
477477
myclient := fake.NewFakeClientWithScheme(setupScheme(), objects...)

0 commit comments

Comments
 (0)