Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 1699fe8

Browse files
authored
Merge pull request #206 from chuckha/makefile
🏃 Update Makefile
2 parents be5a881 + 71b4133 commit 1699fe8

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

Makefile

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ PULL_POLICY ?= Always
3232

3333
# Define Docker related variables. Releases should modify and double check these vars.
3434
REGISTRY ?= gcr.io/$(shell gcloud config get-value project)
35-
CONTROLLER_IMG ?= $(REGISTRY)/cluster-api-kubeadm-controller
35+
STAGING_REGISTRY := gcr.io/k8s-staging-capi-kubeadm
36+
PROD_REGISTRY := us.gcr.io/k8s-artifacts-prod/capi-kubeadm
37+
IMAGE_NAME ?= cluster-api-kubeadm-controller
38+
CONTROLLER_IMG ?= $(REGISTRY)/$(IMAGE_NAME)
3639
TAG ?= dev
3740
ARCH ?= amd64
3841
ALL_ARCH = amd64 arm arm64 ppc64le s390x
@@ -149,6 +152,7 @@ docker-push-manifest: ## Push the fat manifest docker image.
149152
## Minimum docker version 18.06.0 is required for creating and pushing manifest images.
150153
docker manifest create --amend $(CONTROLLER_IMG):$(TAG) $(shell echo $(ALL_ARCH) | sed -e "s~[^ ]*~$(CONTROLLER_IMG)\-&:$(TAG)~g")
151154
@for arch in $(ALL_ARCH); do docker manifest annotate --arch $${arch} ${CONTROLLER_IMG}:${TAG} ${CONTROLLER_IMG}-$${arch}:${TAG}; done
155+
docker manifest push --purge ${CONTROLLER_IMG}:${TAG}
152156
MANIFEST_IMG=$(CONTROLLER_IMG) MANIFEST_TAG=$(TAG) $(MAKE) set-manifest-image
153157

154158
.PHONY: set-manifest-image
@@ -166,16 +170,16 @@ RELEASE_TAG := $(shell git describe --abbrev=0 2>/dev/null)
166170
release: ## Builds and push container images using the latest git tag for the commit.
167171
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
168172
# Push the release image to the staging bucket first.
169-
REGISTRY=gcr.io/k8s-staging-capi-kubeadm TAG=$(RELEASE_TAG) \
173+
REGISTRY=$(STAGING_REGISTRY) TAG=$(RELEASE_TAG) \
170174
$(MAKE) docker-build-all docker-push-all
171175
# Set the manifest image to the production bucket.
172-
REGISTRY=us.gcr.io/k8s-artifacts-prod/capi-kubeadm TAG=$(RELEASE_TAG) \
173-
set-manifest-image
176+
MANIFEST_IMG=$(PROD_REGISTRY)/$(IMAGE_NAME) MANIFEST_TAG=$(RELEASE_TAG) \
177+
$(MAKE) set-manifest-image
174178
# Generate release artifacts.
175179
mkdir -p out/
176180
kustomize build config/default > out/bootstrap-components.yaml
177181

178182
.PHONY: release-staging-latest
179183
release-staging-latest: ## Builds and push container images to the staging bucket using "latest" tag.
180-
REGISTRY=gcr.io/k8s-staging-capi-kubeadm TAG=latest \
184+
REGISTRY=$(STAGING_REGISTRY) TAG=latest \
181185
$(MAKE) docker-build-all docker-push-all

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ require (
1414
k8s.io/client-go v11.0.1-0.20190409021438-1a26190bd76a+incompatible
1515
k8s.io/cluster-bootstrap v0.0.0-20190516232516-d7d78ab2cfe7
1616
k8s.io/klog v0.4.0
17-
sigs.k8s.io/cluster-api v0.0.0-20190830181856-67d897059593
17+
sigs.k8s.io/cluster-api v0.2.0
1818
sigs.k8s.io/controller-runtime v0.2.0
1919
)
2020

2121
replace (
2222
k8s.io/api => k8s.io/api v0.0.0-20190704095032-f4ca3d3bdf1d
2323
k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20190704094733-8f6ac2502e51
24-
sigs.k8s.io/cluster-api => sigs.k8s.io/cluster-api v0.0.0-20190830181856-67d897059593
24+
sigs.k8s.io/cluster-api => sigs.k8s.io/cluster-api v0.2.0
2525
)

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ k8s.io/kube-openapi v0.0.0-20180731170545-e3762e86a74c/go.mod h1:BXM9ceUBTj2QnfH
192192
k8s.io/utils v0.0.0-20190506122338-8fab8cb257d5/go.mod h1:sZAwmy6armz5eXlNoLmJcl4F1QuKu7sr+mFQ0byX7Ew=
193193
k8s.io/utils v0.0.0-20190809000727-6c36bc71fc4a h1:uy5HAgt4Ha5rEMbhZA+aM1j2cq5LmR6LQ71EYC2sVH4=
194194
k8s.io/utils v0.0.0-20190809000727-6c36bc71fc4a/go.mod h1:sZAwmy6armz5eXlNoLmJcl4F1QuKu7sr+mFQ0byX7Ew=
195-
sigs.k8s.io/cluster-api v0.0.0-20190830181856-67d897059593 h1:kR5+NTkokUUyPuTg3T4YI8Ab/MmTjEtlnsEJ1buEkTE=
196-
sigs.k8s.io/cluster-api v0.0.0-20190830181856-67d897059593/go.mod h1:PQFa4RZOESzjF7B8pNOWJSVgUzdAdPbSmuFDz301sgI=
195+
sigs.k8s.io/cluster-api v0.2.0 h1:YjioPI9bdrJ6T2PFUHLfkG/+YdUth73SMIhp3YoONx8=
196+
sigs.k8s.io/cluster-api v0.2.0/go.mod h1:PQFa4RZOESzjF7B8pNOWJSVgUzdAdPbSmuFDz301sgI=
197197
sigs.k8s.io/controller-runtime v0.2.0 h1:5gL30PXOisGZl+Osi4CmLhvMUj77BO3wJeouKF2va50=
198198
sigs.k8s.io/controller-runtime v0.2.0/go.mod h1:ZHqrRDZi3f6BzONcvlUxkqCKgwasGk5FZrnSv9TVZF4=
199199
sigs.k8s.io/testing_frameworks v0.1.1/go.mod h1:VVBKrHmJ6Ekkfz284YKhQePcdycOzNH9qL6ht1zEr/U=

0 commit comments

Comments
 (0)