Skip to content

Commit 71c810a

Browse files
authored
Merge pull request #161 from pohly/mock-test-fixes
prow.sh: fix mock testing
2 parents d7146c7 + 9e438f8 commit 71c810a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

Diff for: prow.sh

+7-5
Original file line numberDiff line numberDiff line change
@@ -303,10 +303,12 @@ tests_need_alpha_cluster () {
303303
# in the e2e.test's normal YAML files.
304304
#
305305
# The default is to enable this for all jobs which use canary images
306-
# because we want to know whether our release candidates will pass all
307-
# existing tests (the storage testsuites and mock testing in
308-
# Kubernetes).
309-
configvar CSI_PROW_E2E_MOCK "$(if [ "${CSI_PROW_DRIVER_CANARY}" = "canary" ]; then echo true; else echo false; fi)" "enable CSI mock volume tests"
306+
# and the latest Kubernetes because those images will be used for mock
307+
# testing once they are released. Using them for mock testing with
308+
# older Kubernetes releases is too risky because the deployment files
309+
# can be very old (for example, still using a removed -provisioner
310+
# parameter in external-provisioner).
311+
configvar CSI_PROW_E2E_MOCK "$(if [ "${CSI_PROW_DRIVER_CANARY}" = "canary" ] && [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ]; then echo true; else echo false; fi)" "enable CSI mock volume tests"
310312

311313
# Regex for non-alpha, feature-tagged tests that should be run.
312314
#
@@ -981,7 +983,7 @@ run_e2e () (
981983
# the full Kubernetes E2E testsuite while only running a few tests.
982984
move_junit () {
983985
if ls "${ARTIFACTS}"/junit_[0-9]*.xml 2>/dev/null >/dev/null; then
984-
run_filter_junit -t="External Storage" -o "${ARTIFACTS}/junit_${name}.xml" "${ARTIFACTS}"/junit_[0-9]*.xml && rm -f "${ARTIFACTS}"/junit_[0-9]*.xml
986+
run_filter_junit -t="External.Storage|CSI.mock.volume" -o "${ARTIFACTS}/junit_${name}.xml" "${ARTIFACTS}"/junit_[0-9]*.xml && rm -f "${ARTIFACTS}"/junit_[0-9]*.xml
985987
fi
986988
}
987989
trap move_junit EXIT

0 commit comments

Comments
 (0)