Skip to content

Commit 682c686

Browse files
authored
Merge pull request #162 from pohly/pod-name-via-shell-command
prow.sh: allow shell commands in CSI_PROW_SANITY_POD
2 parents 36a29f5 + c5f59c5 commit 682c686

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

Diff for: prow.sh

+12-4
Original file line numberDiff line numberDiff line change
@@ -986,9 +986,17 @@ run_e2e () (
986986
run_sanity () (
987987
install_sanity || die "installing csi-sanity failed"
988988
989+
if [[ "${CSI_PROW_SANITY_POD}" =~ " " ]]; then
990+
# Contains spaces, more complex than a simple pod name.
991+
# Evaluate as a shell command.
992+
pod=$(eval "${CSI_PROW_SANITY_POD}") || die "evaluation failed: CSI_PROW_SANITY_POD=${CSI_PROW_SANITY_POD}"
993+
else
994+
pod="${CSI_PROW_SANITY_POD}"
995+
fi
996+
989997
cat >"${CSI_PROW_WORK}/mkdir_in_pod.sh" <<EOF
990998
#!/bin/sh
991-
kubectl exec "${CSI_PROW_SANITY_POD}" -c "${CSI_PROW_SANITY_CONTAINER}" -- mkdir "\$@" && echo "\$@"
999+
kubectl exec "$pod" -c "${CSI_PROW_SANITY_CONTAINER}" -- mkdir "\$@" && echo "\$@"
9921000
EOF
9931001
# Using "rm -rf" as fallback for "rmdir" is a workaround for:
9941002
# Node Service
@@ -1013,8 +1021,8 @@ EOF
10131021
# why it happened.
10141022
cat >"${CSI_PROW_WORK}/rmdir_in_pod.sh" <<EOF
10151023
#!/bin/sh
1016-
if ! kubectl exec "${CSI_PROW_SANITY_POD}" -c "${CSI_PROW_SANITY_CONTAINER}" -- rmdir "\$@"; then
1017-
kubectl exec "${CSI_PROW_SANITY_POD}" -c "${CSI_PROW_SANITY_CONTAINER}" -- rm -rf "\$@"
1024+
if ! kubectl exec "$pod" -c "${CSI_PROW_SANITY_CONTAINER}" -- rmdir "\$@"; then
1025+
kubectl exec "$pod" -c "${CSI_PROW_SANITY_CONTAINER}" -- rm -rf "\$@"
10181026
exit 1
10191027
fi
10201028
EOF
@@ -1033,7 +1041,7 @@ else
10331041
fi
10341042
SCRIPT
10351043
)
1036-
kubectl exec "${CSI_PROW_SANITY_POD}" -c "${CSI_PROW_SANITY_CONTAINER}" -- /bin/sh -c "\${CHECK_PATH}"
1044+
kubectl exec "$pod" -c "${CSI_PROW_SANITY_CONTAINER}" -- /bin/sh -c "\${CHECK_PATH}"
10371045
EOF
10381046
10391047
chmod u+x "${CSI_PROW_WORK}"/*dir_in_pod.sh

0 commit comments

Comments
 (0)