Skip to content

Commit 522361e

Browse files
committed
prow.sh: only run alpha tests for latest Kubernetes release
Commit 7bcee13 added alpha feature gates for Kubernetes 1.19 in the CSI_PROW_E2E_ALPHA_GATES_LATEST variable based on the comment in kubernetes-csi/external-provisioner#493 (comment) that alpha testing only runs for the latest Kubernetes. But some components (like external-health-monitor) are configured with a single Prow job which runs the default set of tests on a stable Kubernetes release (currently 1.17). Those tests used to include alpha testing which then broke during Kind cluster startup because the Kubernetes 1.19 feature gates weren't recognized by 1.17. The solution is to disable alpha testing for Kubernetes != latest in the default set of tests.
1 parent 22c0395 commit 522361e

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

prow.sh

+6-1
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,16 @@ configvar CSI_PROW_DEP_VERSION v0.5.1 "golang dep version to be used for vendor
248248
#
249249
# Unknown or unsupported entries are ignored.
250250
#
251+
# Testing of alpha features is only supported for CSI_PROW_KUBERNETES_VERSION=latest
252+
# because CSI_PROW_E2E_ALPHA and CSI_PROW_E2E_ALPHA_GATES are not set for
253+
# older Kubernetes releases. The script supports that, it just isn't done because
254+
# it is not needed and would cause additional maintenance effort.
255+
#
251256
# Sanity testing with csi-sanity only covers the CSI driver itself and
252257
# thus only makes sense in repos which provide their own CSI
253258
# driver. Repos can enable sanity testing by setting
254259
# CSI_PROW_TESTS_SANITY=sanity.
255-
configvar CSI_PROW_TESTS "unit parallel serial parallel-alpha serial-alpha sanity" "tests to run"
260+
configvar CSI_PROW_TESTS "unit parallel serial $(if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ]; then echo parallel-alpha serial-alpha; fi) sanity" "tests to run"
256261
tests_enabled () {
257262
local t1 t2
258263
# We want word-splitting here, so ignore: Quote to prevent word splitting, or split robustly with mapfile or read -a.

0 commit comments

Comments
 (0)