Skip to content

Commit e0ea2f2

Browse files
committed
Enable tests than can now run on GH actions
Signed-off-by: Mark Rossetti <[email protected]>
1 parent fa8a3d6 commit e0ea2f2

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/windows.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ jobs:
1717
uses: actions/checkout@v2
1818
- name: Run Windows Integration Tests
1919
run: |
20+
# required for running Volume and Disk tests
21+
Install-WindowsFeature -name Hyper-V-PowerShell
22+
2023
$env:CSI_PROXY_GH_ACTIONS="TRUE"
21-
go test -v -race ./integrationtests/...
24+
go test --timeout 20m -v -race ./integrationtests/...
2225
unit_tests:
2326
strategy:
2427
matrix:

integrationtests/disk_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ func TestDisk(t *testing.T) {
7878
})
7979

8080
t.Run("Get/SetDiskState", func(t *testing.T) {
81-
skipTestOnCondition(t, isRunningOnGhActions())
8281

8382
client, err := disk.New(diskapi.New())
8483
require.Nil(t, err)
@@ -143,7 +142,6 @@ func TestDisk(t *testing.T) {
143142
})
144143

145144
t.Run("PartitionDisk", func(t *testing.T) {
146-
skipTestOnCondition(t, isRunningOnGhActions())
147145

148146
var err error
149147
client, err := disk.New(diskapi.New())

integrationtests/volume_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ func TestVolume(t *testing.T) {
2121
negativeVolumeTests(t)
2222
})
2323

24-
// TODO: These tests will fail on Github Actions because Hyper-V is disabled
25-
// see https://github.com/actions/virtual-environments/pull/2525
26-
2724
// these tests should be considered frozen from the API point of view
2825
volumeClient, err := volume.New(volumeapi.New())
2926
require.Nil(t, err)
@@ -32,12 +29,10 @@ func TestVolume(t *testing.T) {
3229
require.Nil(t, err)
3330

3431
t.Run("MountVolume", func(t *testing.T) {
35-
skipTestOnCondition(t, isRunningOnGhActions())
3632
mountVolumeTests(diskClient, volumeClient, t)
3733
})
3834

3935
t.Run("GetClosestVolumeFromTargetPath", func(t *testing.T) {
40-
skipTestOnCondition(t, isRunningOnGhActions())
4136
getClosestVolumeFromTargetPathTests(diskClient, volumeClient, t)
4237
})
4338
}

0 commit comments

Comments
 (0)