Merge pull request #25 from andrewsykim/leader-election-remove-builder

k8s-ci-robot · web-flow · commit b8b7a89535d8 · 2019-04-02T12:09:21.000-07:00
remove builder pattern for leader election due to unexported struct
diff --git a/leaderelection/leader_election.go b/leaderelection/leader_election.go
@@ -107,29 +107,24 @@ func NewLeaderElectionWithConfigMaps(clientset kubernetes.Interface, lockName st
 	}
 }
 
-func (l *leaderElection) WithIdentity(identity string) *leaderElection {
+func (l *leaderElection) WithIdentity(identity string) {
 	l.identity = identity
-	return l
 }
 
-func (l *leaderElection) WithNamespace(namespace string) *leaderElection {
+func (l *leaderElection) WithNamespace(namespace string) {
 	l.namespace = namespace
-	return l
 }
 
-func (l *leaderElection) WithLeaseDuration(leaseDuration time.Duration) *leaderElection {
+func (l *leaderElection) WithLeaseDuration(leaseDuration time.Duration) {
 	l.leaseDuration = leaseDuration
-	return l
 }
 
-func (l *leaderElection) WithRenewDeadline(renewDeadline time.Duration) *leaderElection {
+func (l *leaderElection) WithRenewDeadline(renewDeadline time.Duration) {
 	l.renewDeadline = renewDeadline
-	return l
 }
 
-func (l *leaderElection) WithRetryPeriod(retryPeriod time.Duration) *leaderElection {
+func (l *leaderElection) WithRetryPeriod(retryPeriod time.Duration) {
 	l.retryPeriod = retryPeriod
-	return l
 }
 
 func (l *leaderElection) Run() error {

Original file line number	Diff line number	Diff line change
`@@ -107,29 +107,24 @@ func NewLeaderElectionWithConfigMaps(clientset kubernetes.Interface, lockName st`
`107`	`107`	`}`
`108`	`108`	`}`
`109`	`109`
`110`		`-func (l leaderElection) WithIdentity(identity string) leaderElection {`
	`110`	`+func (l *leaderElection) WithIdentity(identity string) {`
`111`	`111`	`l.identity = identity`
`112`		`- return l`
`113`	`112`	`}`
`114`	`113`
`115`		`-func (l leaderElection) WithNamespace(namespace string) leaderElection {`
	`114`	`+func (l *leaderElection) WithNamespace(namespace string) {`
`116`	`115`	`l.namespace = namespace`
`117`		`- return l`
`118`	`116`	`}`
`119`	`117`
`120`		`-func (l leaderElection) WithLeaseDuration(leaseDuration time.Duration) leaderElection {`
	`118`	`+func (l *leaderElection) WithLeaseDuration(leaseDuration time.Duration) {`
`121`	`119`	`l.leaseDuration = leaseDuration`
`122`		`- return l`
`123`	`120`	`}`
`124`	`121`
`125`		`-func (l leaderElection) WithRenewDeadline(renewDeadline time.Duration) leaderElection {`
	`122`	`+func (l *leaderElection) WithRenewDeadline(renewDeadline time.Duration) {`
`126`	`123`	`l.renewDeadline = renewDeadline`
`127`		`- return l`
`128`	`124`	`}`
`129`	`125`
`130`		`-func (l leaderElection) WithRetryPeriod(retryPeriod time.Duration) leaderElection {`
	`126`	`+func (l *leaderElection) WithRetryPeriod(retryPeriod time.Duration) {`
`131`	`127`	`l.retryPeriod = retryPeriod`
`132`		`- return l`
`133`	`128`	`}`
`134`	`129`
`135`	`130`	`func (l *leaderElection) Run() error {`