Skip to content

Commit 1f92b7e

Browse files
committed
Add ginkgo timeout to e2e tests to help catch any stuck tests
1 parent c10b678 commit 1f92b7e

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Diff for: prow.sh

+9-6
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ configvar CSI_PROW_GINKGO_VERSION v1.7.0 "Ginkgo"
101101

102102
# Ginkgo runs the E2E test in parallel. The default is based on the number
103103
# of CPUs, but typically this can be set to something higher in the job.
104-
configvar CSI_PROW_GINKO_PARALLEL "-p" "Ginko parallelism parameter(s)"
104+
configvar CSI_PROW_GINKGO_PARALLEL "-p" "Ginkgo parallelism parameter(s)"
105+
106+
# Timeout value for the overall ginkgo test suite.
107+
configvar CSI_PROW_GINKGO_TIMEOUT "1h" "Ginkgo timeout"
105108

106109
# Enables building the code in the repository. On by default, can be
107110
# disabled in jobs which only use pre-built components.
@@ -1018,10 +1021,10 @@ run_e2e () (
10181021
10191022
if [ "${name}" == "local" ]; then
10201023
cd "${GOPATH}/src/${CSI_PROW_SIDECAR_E2E_IMPORT_PATH}" &&
1021-
run_with_loggers env KUBECONFIG="$KUBECONFIG" KUBE_TEST_REPO_LIST="$(if [ -e "${CSI_PROW_WORK}/e2e-repo-list" ]; then echo "${CSI_PROW_WORK}/e2e-repo-list"; fi)" ginkgo -v "$@" "${CSI_PROW_WORK}/e2e-local.test" -- -report-dir "${ARTIFACTS}" -report-prefix local
1024+
run_with_loggers env KUBECONFIG="$KUBECONFIG" KUBE_TEST_REPO_LIST="$(if [ -e "${CSI_PROW_WORK}/e2e-repo-list" ]; then echo "${CSI_PROW_WORK}/e2e-repo-list"; fi)" ginkgo --timeout="${CSI_PROW_GINKGO_TIMEOUT}" -v "$@" "${CSI_PROW_WORK}/e2e-local.test" -- -report-dir "${ARTIFACTS}" -report-prefix local
10221025
else
10231026
cd "${GOPATH}/src/${CSI_PROW_E2E_IMPORT_PATH}" &&
1024-
run_with_loggers env KUBECONFIG="$KUBECONFIG" KUBE_TEST_REPO_LIST="$(if [ -e "${CSI_PROW_WORK}/e2e-repo-list" ]; then echo "${CSI_PROW_WORK}/e2e-repo-list"; fi)" ginkgo -v "$@" "${CSI_PROW_WORK}/e2e.test" -- -report-dir "${ARTIFACTS}" -storage.testdriver="${CSI_PROW_WORK}/test-driver.yaml"
1027+
run_with_loggers env KUBECONFIG="$KUBECONFIG" KUBE_TEST_REPO_LIST="$(if [ -e "${CSI_PROW_WORK}/e2e-repo-list" ]; then echo "${CSI_PROW_WORK}/e2e-repo-list"; fi)" ginkgo --timeout="${CSI_PROW_GINKGO_TIMEOUT}" -v "$@" "${CSI_PROW_WORK}/e2e.test" -- -report-dir "${ARTIFACTS}" -storage.testdriver="${CSI_PROW_WORK}/test-driver.yaml"
10251028
fi
10261029
)
10271030
@@ -1310,7 +1313,7 @@ main () {
13101313
if tests_enabled "parallel"; then
13111314
# Ignore: Double quote to prevent globbing and word splitting.
13121315
# shellcheck disable=SC2086
1313-
if ! run_e2e parallel ${CSI_PROW_GINKO_PARALLEL} \
1316+
if ! run_e2e parallel ${CSI_PROW_GINKGO_PARALLEL} \
13141317
-focus="$focus" \
13151318
-skip="$(regex_join "${CSI_PROW_E2E_SERIAL}" "${CSI_PROW_E2E_ALPHA}" "${CSI_PROW_E2E_SKIP}")"; then
13161319
warn "E2E parallel failed"
@@ -1320,7 +1323,7 @@ main () {
13201323
# Run tests that are feature tagged, but non-alpha
13211324
# Ignore: Double quote to prevent globbing and word splitting.
13221325
# shellcheck disable=SC2086
1323-
if ! run_e2e parallel-features ${CSI_PROW_GINKO_PARALLEL} \
1326+
if ! run_e2e parallel-features ${CSI_PROW_GINKGO_PARALLEL} \
13241327
-focus="$focus.*($(regex_join "${CSI_PROW_E2E_FOCUS}"))" \
13251328
-skip="$(regex_join "${CSI_PROW_E2E_SERIAL}")"; then
13261329
warn "E2E parallel features failed"
@@ -1368,7 +1371,7 @@ main () {
13681371
if tests_enabled "parallel-alpha"; then
13691372
# Ignore: Double quote to prevent globbing and word splitting.
13701373
# shellcheck disable=SC2086
1371-
if ! run_e2e parallel-alpha ${CSI_PROW_GINKO_PARALLEL} \
1374+
if ! run_e2e parallel-alpha ${CSI_PROW_GINKGO_PARALLEL} \
13721375
-focus="$focus.*($(regex_join "${CSI_PROW_E2E_ALPHA}"))" \
13731376
-skip="$(regex_join "${CSI_PROW_E2E_SERIAL}" "${CSI_PROW_E2E_SKIP}")"; then
13741377
warn "E2E parallel alpha failed"

0 commit comments

Comments
 (0)